From: Steven Scott <steven@codemettle.com>
To: Jeff King <peff@peff.net>
Cc: Will Palmer <wmpalmer@gmail.com>,
Eric Wong <normalperson@yhbt.net>, git <git@vger.kernel.org>
Subject: Re: [BUG] git-svn fails to rename files with %20 in filename
Date: Wed, 2 Mar 2011 10:27:29 -0500 [thread overview]
Message-ID: <AANLkTimQTwSPnyNBBNnSYLStZqQvBjWk0ydOpcw1UiwO@mail.gmail.com> (raw)
In-Reply-To: <20110223100431.GD9222@sigill.intra.peff.net>
On Wed, Feb 23, 2011 at 5:04 AM, Jeff King <peff@peff.net> wrote:
>
> On Tue, Feb 22, 2011 at 04:50:15PM +0000, Will Palmer wrote:
>
> > > IOW, it looks like the path we hand to svn needs url-encoding even for
> > > the local case (which make sense, as it is a file:// url). But I know
> > > nothing about svn, so probably I am breaking some other weird non-url
> > > local case. :)
> > >
> >
> > Unless I've got my line-numbers mixed up, the commit which introduced
> > the https-specific encoding behaviour,
> > 29633bb91c git-svn: fix commiting renames over DAV with funky file names
> >
> > seems to be of the opinion that the bug did not effect file:// and
> > svn:// URLs. Has something changed?
>
> Yeah, what we are seeing definitely contradicts that commit. It's been
> 3.5 years; maybe something was tweaked in the subversion library? I
> tried reading the code, but I got lost amidst all of the nasty perl
> bindings. I couldn't find anything relevant in svn's changelog or in
> google, either.
>
In my case, I *was* using http://, and applying that patch (to remove
the HTTP check) didn't work. Same error as earlier in the thread. I
thought it worked once, but I eventually saw it fail again. git-svn is
definitely broken if the URL has a %20 in it, and it's quite useless
when you never know when you'll be unable to dcommit and manually have
to generate patches and apply them to a svn repository.
Thankfully I got my team to switch to git, so best of luck to the rest
of you trying to use git-svn when a doofus put a space in the URL :)
--
Steven Scott
next prev parent reply other threads:[~2011-03-02 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 10:12 [BUG] git-svn fails to rename files with %20 in filename Will Palmer
2011-02-21 12:31 ` Jeff King
2011-02-22 16:50 ` Will Palmer
2011-02-23 10:04 ` Jeff King
2011-03-02 15:27 ` Steven Scott [this message]
2011-02-21 15:26 ` Steven Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimQTwSPnyNBBNnSYLStZqQvBjWk0ydOpcw1UiwO@mail.gmail.com \
--to=steven@codemettle.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=peff@peff.net \
--cc=wmpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).