From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: "Santi Béjar" <santi@agolina.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sha1_name: allow to add @{...} alias via config
Date: Wed, 8 Sep 2010 20:12:49 +1000 [thread overview]
Message-ID: <AANLkTimR35gKwXg9Ve5y2SqaxyxcM410h3p=eM9cHWY2@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin83BQ0YhWHuDqkY4HYWP9+bUso1BDNbFtRskDp@mail.gmail.com>
2010/9/8 Santi Béjar <santi@agolina.net>:
> 2010/9/8 Santi Béjar <santi@agolina.net>:
>> 2010/9/8 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
>>> This allows users to add new @{..} alias via ref-at.* config
>>> variables. The rewrite rule is printf-alike.
>>
>> Another issue is that it can shadow builtin @{}s, like @{upstream}.
>
> In fact this patch breaks @{upstream}.
My fault. There should not be an equal in
if (substitute_ref_at(&new_str, str) >= 0)
--
Duy
next prev parent reply other threads:[~2010-09-08 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 4:04 [PATCH] sha1_name: allow to add @{...} alias via config Nguyễn Thái Ngọc Duy
2010-09-08 9:45 ` Santi Béjar
2010-09-08 9:53 ` Santi Béjar
2010-09-08 10:12 ` Nguyen Thai Ngoc Duy [this message]
2010-09-08 10:11 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimR35gKwXg9Ve5y2SqaxyxcM410h3p=eM9cHWY2@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=santi@agolina.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).