From: Elijah Newren <newren@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] fast-export: ensure that a renamed file is printed after all references
Date: Wed, 8 Sep 2010 13:26:14 -0600 [thread overview]
Message-ID: <AANLkTimS96c1YFC+UUw0iRoPVT=COFhDRoSO1cNHYhTf@mail.gmail.com> (raw)
In-Reply-To: <201009082047.50083.j6t@kdbg.org>
On Wed, Sep 8, 2010 at 12:47 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> On Mittwoch, 8. September 2010, Elijah Newren wrote:
>> Patch and description looks good to me...however, I was a little
>> surprised to see no testsuite addition or additional explanation. Are
>> you seeing some t9350 tests fail on some platform despite passing on
>> linux?
>
> Yes, I see the problem in t9350 on Windows. It is impossible to write a test
> for it because the test would depend on the unspecified behavior of qsort.
Makes sense. Would it be worth briefly mentioning Windows in the
commit message?
Either way,
Acked-by: Elijah Newren <newren@gmail.com>
> BTW, I don't know whether the diff machinery guarantees to produce 'C' and 'R'
> records in this order. If there is no such guarantee, then fast-export would
> have been broken even before 060df62.
prev parent reply other threads:[~2010-09-08 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 19:33 [PATCH] fast-export: ensure that a renamed file is printed after all references Johannes Sixt
2010-09-08 5:46 ` Elijah Newren
2010-09-08 18:47 ` Johannes Sixt
2010-09-08 19:26 ` Elijah Newren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimS96c1YFC+UUw0iRoPVT=COFhDRoSO1cNHYhTf@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).