From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Tor Arntsen <tor@spacetec.no>
Cc: Tait <git.git@t41t.com>, git@vger.kernel.org
Subject: Re: Minimum Perl version?
Date: Fri, 24 Sep 2010 11:05:24 +0000 [thread overview]
Message-ID: <AANLkTimUE=hyJ-y_XzpvCokb77KvRGw3gnM+9Xxui9tG@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=3xNSV0y-i=0KUSDRBJ8HmfSfGO7TBHTPiv_KM@mail.gmail.com>
On Fri, Sep 24, 2010 at 10:27, Tor Arntsen <tor@spacetec.no> wrote:
> On Fri, Sep 24, 2010 at 12:00, Tait <git.git@t41t.com> wrote:
>>
>> What is the minimum Perl version git expects to support?
>>
>> I ask, because f922df8... seems to have introduced a open() syntax that
>> is not compatible with some older Perl versions.
>
> I've found that for add -p you'll need 5.8.x or newer, due to stuff like
>
> my $fh = undef;
> open($fh, '-|', @_) or die;
>
> which fails in e.g. perl 5.6.
> There could be some other stuff (in addition to add -p) that also does
> this kind of thing.
If that's the case (I don't have a 5.6 here to do archeology on) then
git add -p never worked in 5.6. That was added in 5cde71d6 when it was
introduced in 2006:
+sub run_cmd_pipe {
+ my $fh = undef;
+ open($fh, '-|', @_) or die;
+ return <$fh>;
+}
Can you show us the specific error you're getting, and the output of
your `perl -V` ?
next prev parent reply other threads:[~2010-09-24 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 10:00 Minimum Perl version? Tait
2010-09-24 10:23 ` Ævar Arnfjörð Bjarmason
2010-09-24 20:40 ` Tait
2010-09-24 22:39 ` Ævar Arnfjörð Bjarmason
2010-09-26 10:22 ` Andreas Ericsson
2010-09-24 10:27 ` Tor Arntsen
2010-09-24 11:05 ` Ævar Arnfjörð Bjarmason [this message]
2010-09-24 11:22 ` Tor Arntsen
2010-09-24 12:30 ` Alex Riesen
2010-09-24 12:42 ` Tor Arntsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimUE=hyJ-y_XzpvCokb77KvRGw3gnM+9Xxui9tG@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git.git@t41t.com \
--cc=git@vger.kernel.org \
--cc=tor@spacetec.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).