From: xzer <xiaozhu@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] generate a valid rfc2047 mail header for multi-line subject.
Date: Thu, 24 Feb 2011 00:16:04 +0900 [thread overview]
Message-ID: <AANLkTimUXqKdTDcSVDK44XPhxWbHtQuDWHMED3PKqWE4@mail.gmail.com> (raw)
In-Reply-To: <20110223094844.GA9205@sigill.intra.peff.net>
2011/2/23 Jeff King <peff@peff.net>:
> On Wed, Feb 23, 2011 at 03:08:54AM -0500, Jeff King wrote:
>
>> Yeah, I think the best path forward is:
>>
>> 1. Stop feeding "pre-folded" subject lines to the email formatter.
>> Give it the regular subject line with no newlines.
>>
>> 2. rfc2047 encoding should encode a literal newline. Which should
>> generally never happen, but is probably the most sane thing to do
>> if it does.
>>
>> 3. rfc2047 should fold all lines at some sane length. As it is now, we
>> may sometimes generate long lines in headers (though in practice, I
>> doubt this is much of a problem).
>
> So here is a series that does this. It still doesn't preserve subject
> newlines in "format-patch | am", but I don't think that was ever a goal
> of the code. If we want to add it as an optional feature on top (maybe
> as part of "-k"?), it should be easy to do (since the rfc2047 encoding
> will now preserve embedded newlines).
>
> [1/3]: strbuf: add fixed-length version of add_wrapped_text
> [2/3]: format-patch: wrap long header lines
> [3/3]: format-patch: rfc2047-encode newlines in headers
>
> -Peff
>
To the first point, I really want to find a way that we can remain the
line breaker
after import a formatted patch. That's why I add a new function to product multi
line header, I want to do something which is special to subject. In my usage,
I told my men every day that don't write too long in the first
paragraph, but there
are always somebody who forgets it, then I will get a patch with a
very long subject
just like a nightmare(yes, I gave them my temporary fix which I submitted here,
so they can write as long as they want).
So I want to know whether we can generate a 2047 compatible header so
that mailer
can catch it correctly and the git-am can import it with line breaker
correctly too.
next prev parent reply other threads:[~2011-02-23 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 8:09 [PATCH] generate a valid rfc2047 mail header for multi-line subject xzer
2011-02-22 20:43 ` Junio C Hamano
2011-02-23 8:08 ` Jeff King
2011-02-23 9:48 ` Jeff King
2011-02-23 9:50 ` [PATCH 1/3] strbuf: add fixed-length version of add_wrapped_text Jeff King
2011-02-23 9:58 ` [PATCH 2/3] format-patch: wrap long header lines Jeff King
2011-02-23 9:59 ` [PATCH 3/3] format-patch: rfc2047-encode newlines in headers Jeff King
2011-02-23 21:47 ` Junio C Hamano
2011-02-24 7:15 ` Jeff King
2011-02-23 15:16 ` xzer [this message]
2011-02-23 16:35 ` [PATCH] generate a valid rfc2047 mail header for multi-line subject Jeff King
2011-02-23 17:34 ` Junio C Hamano
2011-02-24 7:34 ` Jeff King
2011-02-23 15:34 ` xzer
2011-02-23 17:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimUXqKdTDcSVDK44XPhxWbHtQuDWHMED3PKqWE4@mail.gmail.com \
--to=xiaozhu@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).