git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: Petr Baudis <pasky@suse.cz>,
	git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
	Petr Baudis <pasky@ucw.cz>
Subject: Re: [RFC/PATCH 1/4] gitweb: Move subroutines to Gitweb::Config module
Date: Wed, 9 Jun 2010 15:13:34 +0200	[thread overview]
Message-ID: <AANLkTimXSfAqMYVIQcepibeDlJPOKE4hTlys9laEFTHo@mail.gmail.com> (raw)
In-Reply-To: <201006090138.52125.jnareb@gmail.com>

On Wed, Jun 9, 2010 at 1:38 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> On Tue, 8 Jun 2010, Petr Baudis wrote:
>>
>>   I thought we already discussed MVC and sort of agreed that it's an
>> overkill at this point. At least that is still my opinion on it; I'm not
>> opposed to MVC per se, but to me, this modularization is a good
>> intermediate step even if we go the MVC way later, and doing MVC properly
>> would mean much huger large-scale refactoring than just naming a module
>> Gitweb::View instead of Gitweb::HTML. Let's do it not at all, or
>> properly sometime later. I think it's well out-of-scope for GSoC.
>
> So it would be enough to have Gitweb with core of gitweb, gitweb.perl
> top-level script, Gitweb::Write or something like that for new write
> functionality and Gitweb::Util containing things that are needed by Gitweb
> and by Gitweb::Write(r).

Sidenote (something I meant to write, but forgot): SVN::Web[1][2] and
Gitalist[3][4] might or might not be good example on how to split gitweb
into modules.

[1] http://p3rl.org/SVN::Web
    http://search.cpan.org/dist/SVN-Web/
[2] http://jc.ngo.org.uk/svnweb/jc/browse/nik/CPAN/SVN-Web/trunk/

[3] http://p3rl.org/Gitalist
    http://search.cpan.org/dist/Gitalist/
[4] http://github.com/broquaint/Gitalist
-- 
Jakub Narebski

      reply	other threads:[~2010-06-09 13:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 20:50 [RFC/PATCH 1/4] gitweb: Move subroutines to Gitweb::Config module Pavan Kumar Sunkara
2010-06-07 20:50 ` [RFC/PATCH 2/4] gitweb: Create Gitweb::HTML::Link module Pavan Kumar Sunkara
2010-06-07 20:50 ` [RFC/PATCH 3/4] gitweb: Create Gitweb::HTML module Pavan Kumar Sunkara
2010-06-07 20:50 ` [RFC/PATCH 4/4] gitweb: Create Gitweb::HTML::String module Pavan Kumar Sunkara
2010-06-07 20:58   ` Pavan Kumar Sunkara
2010-06-08 12:46 ` [RFC/PATCH 1/4] gitweb: Move subroutines to Gitweb::Config module Jakub Narebski
2010-06-08 13:50   ` Ævar Arnfjörð Bjarmason
2010-06-12  1:01     ` Jakub Narebski
2010-06-12  1:22       ` Ævar Arnfjörð Bjarmason
2010-06-12  1:41         ` Jakub Narebski
2010-06-08 14:13   ` Petr Baudis
2010-06-08 19:22     ` Pavan Kumar Sunkara
2010-06-08 19:55       ` Petr Baudis
2010-06-08 20:24         ` Pavan Kumar Sunkara
2010-06-08 20:50           ` Petr Baudis
2010-06-08 23:38       ` Jakub Narebski
2010-06-09 13:13         ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimXSfAqMYVIQcepibeDlJPOKE4hTlys9laEFTHo@mail.gmail.com \
    --to=jnareb@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    --cc=pasky@ucw.cz \
    --cc=pavan.sss1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).