From: "Santi Béjar" <santi@agolina.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/resend] Doc: git-push: Specify the default mode in the description
Date: Tue, 9 Nov 2010 13:23:20 +0100 [thread overview]
Message-ID: <AANLkTimYTRvOb1SjjUyANuTX2sCRKj17bLMbkKKG3rFg@mail.gmail.com> (raw)
In-Reply-To: <7vy693o833.fsf@alter.siamese.dyndns.org>
On Mon, Nov 8, 2010 at 9:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Santi Béjar <santi@agolina.net> writes:
>
>> Signed-off-by: Santi Béjar <santi@agolina.net>
>> ---
>> Hi *,
>>
>> just resend a patch that maybe was missed inside this thread:
>
> No, I didn't miss it.
>
> The new text says 'push "matching" branches' before explaining what it is,
> only vaguely refers the reader to the next section by "see below" without
> telling which part of below the reader should look at. In other words, it
> wastes two lines without adding two lines worth of additional information.
>
> Saying "look for string 'default' below" might be an improvement ;-), but
> then the reader can do that without being told to do so themselves, so...
At least with the new text the reader will know what to look for. She
has to look for "matching" and not the generic "default". BTW, I'll
send another patch with the explanation of matching, but it just
repeats what is written in the <refspec> option...
Another option would be to add "see the <refspec> option below",
although is is already implicit as the paragraph begins with "if no
explicit refspec".
Santi
next prev parent reply other threads:[~2010-11-09 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 13:20 [PATCH/resend] Doc: git-push: Specify the default mode in the description Santi Béjar
2010-11-08 20:48 ` Junio C Hamano
2010-11-09 12:23 ` Santi Béjar [this message]
2010-11-09 12:24 ` [PATCHv2] " Santi Béjar
2010-11-10 0:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimYTRvOb1SjjUyANuTX2sCRKj17bLMbkKKG3rFg@mail.gmail.com \
--to=santi@agolina.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).