git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Gary V. Vaughan" <gary@thewrittenword.com>,
	Boyd Lynn Gerber <gerberb@zenez.com>,
	Brandon Casey <drafnel@gmail.com>,
	Jason Riedy <ejr@EECS.Berkeley.EDU>,
	Robert Schiele <rschiele@gmail.com>
Subject: NO_REGEX defaults on obscure platforms
Date: Wed, 8 Sep 2010 15:12:35 +0000	[thread overview]
Message-ID: <AANLkTimYY_KHwqWWXTxFqW67FHYtJJkLuA-6WVc6wzO5@mail.gmail.com> (raw)

On Mon, Sep 6, 2010 at 07:41, Junio C Hamano <gitster@pobox.com> wrote:

> There are a few leftover bits in 'next' that need to be merged to 'master'
> before we declare a real -rc cycle, so tonight's pushout is -rc0.

One thing that's almost certainly wrong in v1.7.3-rc0 is the NO_REGEX
defaults. It's a non-issue for people who run the configure script,
but the Makefile probably has the wrong defaults on some obscure
platforms.

I've CC'd people involved in Tru64, UnixWare, SCO, HP/UX, IRIX etc. It
would be really useful if you could:

  1. Get v1.7.3-rc0
  2. Compile with the defaults, and NO_REGEX=YesPlease
  3. Run `cd t && ./t7008-grep-binary.sh` and report the results.

That test is probably failing on some of these platforms.

Alternatively, just check for REG_STARTEND in regex.h (or the includes
it pulls in):

    $ grep REG_STARTEND /usr/include/regex.h
    #define REG_STARTEND (1 << 2)

             reply	other threads:[~2010-09-08 15:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 15:12 Ævar Arnfjörð Bjarmason [this message]
2010-09-08 15:31 ` NO_REGEX defaults on obscure platforms Brandon Casey
2010-09-08 17:20   ` Jakub Narebski
2010-09-09 19:15   ` [PATCH 1/2] t/t7008: workaround broken handling of \000 by printf on IRIX Brandon Casey
2010-09-09 19:15   ` [PATCH 2/2] Makefile: use compat regex on IRIX 6.5 Brandon Casey
2010-09-10  0:10     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimYY_KHwqWWXTxFqW67FHYtJJkLuA-6WVc6wzO5@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=drafnel@gmail.com \
    --cc=ejr@EECS.Berkeley.EDU \
    --cc=gary@thewrittenword.com \
    --cc=gerberb@zenez.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rschiele@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).