From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Christian Couder <chriscool@tuxfamily.org>,
Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 1/2] commit: add parse_commit_repl() to replace commits at parsing time
Date: Wed, 18 Aug 2010 14:37:02 +1000 [thread overview]
Message-ID: <AANLkTimZOOMnbbu_gHoeE2Bo_uDajN6Nw64eOtRFfVmM@mail.gmail.com> (raw)
In-Reply-To: <20100818042459.GD21185@burratino>
On Wed, Aug 18, 2010 at 2:24 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Christian Couder wrote:
>
>> The downside is that the sha1 will not be
>> consistent with the content anymore and that it will be more difficult to
>> realize that an object has been replaced as there will be no sha1 change to be
>> seen.
>
> Maybe in the long run it would make sense to keep a "replaced" flag
> and use it to mark the replace objects specially in some user-facing
> commands (like log --format=medium).
Sounds good (if uses really need to know that). It can be used for
commit grafts too.
You would need to find an available bit flag first though. Currently
object.flags is used for different purposes and its bit definitions
are not centralized. So it's hard to find a "good" bit that no one
uses yet, to become the "replaced" bit. OK I'm getting off-topic now.
--
Duy
next prev parent reply other threads:[~2010-08-18 4:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 1:58 [RFC/PATCH 1/2] commit: add parse_commit_repl() to replace commits at parsing time Christian Couder
2010-08-17 21:18 ` Junio C Hamano
2010-08-18 3:17 ` Nguyen Thai Ngoc Duy
2010-08-18 4:07 ` Christian Couder
2010-08-18 4:24 ` Jonathan Nieder
2010-08-18 4:37 ` Nguyen Thai Ngoc Duy [this message]
2010-08-18 14:50 ` Junio C Hamano
2010-08-20 4:04 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimZOOMnbbu_gHoeE2Bo_uDajN6Nw64eOtRFfVmM@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).