From: Elijah Newren <newren@gmail.com>
To: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 00/95] Add missing &&'s in the testsuite
Date: Fri, 24 Sep 2010 15:54:50 -0600 [thread overview]
Message-ID: <AANLkTimdp1+urRt5kwo=1OEg5X-2mAZ6OWQvdyyAWZRt@mail.gmail.com> (raw)
In-Reply-To: <UA25cdpM3towJy13l2VNc8pgKHGybUWr88Zc0C9kQjUCExhj5gXkCQ@cipher.nrlssc.navy.mil>
On Fri, Sep 24, 2010 at 3:32 PM, Brandon Casey
<brandon.casey.ctr@nrlssc.navy.mil> wrote:
> Sounds like it should be about a 16 patch series.
>
> The first 15 patches should rework the tests that will fail when
> they are hooked together properly with &&'s.
Actually, only 9 of the tests fail when hooked together with &&'s and
needed extra fixes because of this. 4 of the tests modify the code
slightly in order to chain it together (e.g. replacing "a_command ||
return 1; command_that_fails" with "a_command && test_might_fail
command_that_fails &&"), 1 removes a stray "1" at the end of the file,
and one fixes lack of chaining by modifying tests to use
test_exit_code instead of test_expect_success (namely tests that did
nothing but check the exit code of a single command).
> And then one patch to mechanically add the missing &&'s.
Sure, I can include that change for the next round.
Thanks for the feedback.
Elijah
next prev parent reply other threads:[~2010-09-24 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 21:06 [RFC PATCH 00/95] Add missing &&'s in the testsuite Elijah Newren
2010-09-24 21:32 ` Brandon Casey
2010-09-24 21:54 ` Elijah Newren [this message]
2010-09-24 22:02 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimdp1+urRt5kwo=1OEg5X-2mAZ6OWQvdyyAWZRt@mail.gmail.com' \
--to=newren@gmail.com \
--cc=brandon.casey.ctr@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).