git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>, git@vger.kernel.org
Subject: Re: When to use test_commit (Re: [PATCH] checkout: add a test for  creating a new branch with regexp as a starting point)
Date: Fri, 30 Jul 2010 20:20:40 +0000	[thread overview]
Message-ID: <AANLkTimeQA2_fQ_f2pQchbo1coj3=mV9TRPnbET8SQ4F@mail.gmail.com> (raw)
In-Reply-To: <20100730191357.GA2448@burratino>

On Fri, Jul 30, 2010 at 19:13, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> And actually, we should probably have a
>> test_commit_notag() then.
>
> I don’t know.  What’s so bad about using "git commit" directly?

Nothing, it's just easier to write and read the tests when we have and
use functions for these common operations.

> I often find myself using "git commit" in tests because test_commit
> imposes all the usual restrictions for a ref name on the commit
> message.  I would happily use an abbreviation for
>
>  test_tick &&
>  git commit -m "something" &&
>  git tag something-else
>
> if available because I don’t like typing, but would that help the
> reader and test runner any?

Maybe just introduce a fourth argument to test_commit, to make it
<message> [<file> [<contents> [<tagname>]] instead of <message>
[<file> [<contents>]] ?

  reply	other threads:[~2010-07-30 20:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 22:01 [PATCH] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-29 23:07 ` Ævar Arnfjörð Bjarmason
2010-07-29 23:36   ` Thomas Rast
2010-07-30  8:44     ` Dmitry V. Levin
2010-07-30 11:54       ` Ævar Arnfjörð Bjarmason
2010-07-30 19:13         ` When to use test_commit (Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point) Jonathan Nieder
2010-07-30 20:20           ` Ævar Arnfjörð Bjarmason [this message]
2010-07-31  0:18             ` [PATCH 1/2] test-lib.sh: introduce 4th argument to test_commit() specifying a tag name Dmitry V. Levin
2010-07-31  0:39               ` Ævar Arnfjörð Bjarmason
2010-07-31  1:56                 ` [PATCH 1/2 v2] " Dmitry V. Levin
2010-07-31 10:23                   ` Ævar Arnfjörð Bjarmason
2010-07-31  0:19             ` [PATCH 2/2] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-31  0:44               ` Ævar Arnfjörð Bjarmason
2010-07-31  1:44                 ` [PATCH 2/2 v2] " Dmitry V. Levin
2010-07-31 10:24                   ` Ævar Arnfjörð Bjarmason
2010-08-05 21:24                     ` [PATCH 2/2 v3] " Dmitry V. Levin
2010-08-02 21:04     ` [PATCH] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimeQA2_fQ_f2pQchbo1coj3=mV9TRPnbET8SQ4F@mail.gmail.com' \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).