From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Julien Cristau <jcristau@debian.org>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org
Subject: Re: [PATCH] config --get --path: check for unset $HOME
Date: Mon, 26 Jul 2010 16:35:56 +0000 [thread overview]
Message-ID: <AANLkTimf73aczIILlQ5N_id97kJNmGAUf0QLlMl8my2r@mail.gmail.com> (raw)
In-Reply-To: <20100726150651.GA4021@burratino>
On Mon, Jul 26, 2010 at 15:06, Jonathan Nieder <jrnieder@gmail.com> wrote:
> size_t username_len = first_slash - username;
> if (username_len == 0) {
> const char *home = getenv("HOME");
> + if (!home)
> + goto return_null;
> strbuf_add(&user_path, home, strlen(home));
> } else {
> struct passwd *pw = getpw_str(username, username_len);
Should we maybe fall back on checking pw_dir in getpwuid() if $HOME isn't set?
next prev parent reply other threads:[~2010-07-26 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100723003456.2976.899.reportbug@dr-wily.mit.edu>
[not found] ` <20100723012322.GA27113@burratino>
[not found] ` <20100725085939.GA5281@radis.liafa.jussieu.fr>
[not found] ` <20100726005111.GA29755@burratino>
[not found] ` <20100726140756.GH12476@radis.liafa.jussieu.fr>
2010-07-26 15:06 ` [PATCH] config --get --path: check for unset $HOME Jonathan Nieder
2010-07-26 15:33 ` Julien Cristau
2010-07-26 16:35 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-26 17:08 ` Jonathan Nieder
2010-07-26 17:48 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimf73aczIILlQ5N_id97kJNmGAUf0QLlMl8my2r@mail.gmail.com \
--to=avarab@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=jcristau@debian.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).