From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] enable "no-done" extension only when fetching over smart-http
Date: Tue, 29 Mar 2011 10:24:12 -0700 [thread overview]
Message-ID: <AANLkTimg5_9dQDq8Xa9pJsx9f6UrNewih+WirKcOP42i@mail.gmail.com> (raw)
In-Reply-To: <7vlizxsv82.fsf@alter.siamese.dyndns.org>
On Tue, Mar 29, 2011 at 10:16, Junio C Hamano <gitster@pobox.com> wrote:
> When 'no-done' protocol extension is used, the upload-pack (i.e. the
> server side) process stops listening to the fetch-pack after issuing the
> final NAK, and starts sending the generated pack data back, but there may
> be more "have" send by the latter in flight that the fetch-pack is
> expecting to be responded with ACK/NAK. This will typically result in a
> deadlock (both will block on write that the other end never reads) or
> SIGPIPE on the fetch-pack end (upload-pack will finish writing a small
> pack and goes away).
>
> Disable it unless fetch-pack is running under smart-http, where there is
> no such streaming issue.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
--
Shawn.
next prev parent reply other threads:[~2011-03-29 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 17:16 [PATCH] enable "no-done" extension only when fetching over smart-http Junio C Hamano
2011-03-29 17:24 ` Shawn Pearce [this message]
2011-03-29 17:24 ` [PATCH] enable "no-done" extension only when serving " Junio C Hamano
2011-03-29 17:31 ` Shawn Pearce
2011-03-29 17:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimg5_9dQDq8Xa9pJsx9f6UrNewih+WirKcOP42i@mail.gmail.com \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).