From: Dave Abrahams <dave@boostpro.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: Re: cherry-pick / pre-commit hook?
Date: Mon, 27 Dec 2010 12:33:27 -0900 [thread overview]
Message-ID: <AANLkTimhMa+zGp+MNi9fjwNsAaMWz3VG=KERoDo7c0zA@mail.gmail.com> (raw)
In-Reply-To: <7vipyfx79g.fsf@alter.siamese.dyndns.org>
On Mon, Dec 27, 2010 at 11:58 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Dave Abrahams wrote:
>>
>>> if you're going to have a "pre-commit hook" concept,
>>> but not run that hook for some kinds of commits, then that fact needs
>>> to be documented.
>>
>> True, and thanks for a reminder. Suggested wording?
>>
>> The current githooks(5) says
>>
>> pre-commit
>> This hook is invoked by git commit, and can be bypassed with
>> --no-verify option.
>>
>> and leaves the question of whether it is invoked by git cherry-pick
>> unanswered.
>
> Huh? Isn't it very clear that "git commit" calls it and "git status" or
> anything that is not "git commit" doesn't?
Not to me. And is it really true? What about rebase? What about merge?
--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
next prev parent reply other threads:[~2010-12-27 21:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 17:10 cherry-pick / pre-commit hook? Dave Abrahams
2010-12-08 17:53 ` Jonathan Nieder
2010-12-08 21:22 ` Dave Abrahams
2010-12-08 22:05 ` Jonathan Nieder
2010-12-27 2:18 ` Dave Abrahams
2010-12-27 9:37 ` Jonathan Nieder
2010-12-27 20:58 ` Junio C Hamano
2010-12-27 21:33 ` Dave Abrahams [this message]
2010-12-28 18:16 ` Junio C Hamano
2010-12-28 22:38 ` Jakub Narebski
2010-12-29 1:00 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimhMa+zGp+MNi9fjwNsAaMWz3VG=KERoDo7c0zA@mail.gmail.com' \
--to=dave@boostpro.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).