From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, robbat2@gentoo.org, casey@nrlssc.navy.mil
Subject: Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags.
Date: Sat, 25 Sep 2010 14:27:02 +0000 [thread overview]
Message-ID: <AANLkTimj--jZdX++=ZjF3A0HE11FbkgVb2gs3ADVEGvx@mail.gmail.com> (raw)
In-Reply-To: <1285421633-22684-3-git-send-email-jon.seymour@gmail.com>
On Sat, Sep 25, 2010 at 13:33, Jon Seymour <jon.seymour@gmail.com> wrote:
> + : >expected &&
We've been dropping the ":>foo" style in favor of ">foo" in other
tests. There's no need for the ":".
> + echo -X > expected &&
> + echo -q > expected &&
> + echo -X > expected &&
> + echo --no-flags > expected &&
Maybe some echo implementations don't like flag-like params, and we need:
printf "%s\n" "-X"
here. I don't know whether that's the case.
next prev parent reply other threads:[~2010-09-25 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 13:33 [PATCH v4 0/4] rev-parse: allow --flags to output rev-parse-like flags Jon Seymour
2010-09-25 13:33 ` [PATCH v4 1/4] rev-parse: stop interpreting flags as options to rev-parse once --flags is specified Jon Seymour
2010-09-25 13:33 ` [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags Jon Seymour
2010-09-25 14:27 ` Ævar Arnfjörð Bjarmason [this message]
2010-09-25 16:19 ` Jon Seymour
2010-09-25 13:33 ` [PATCH v4 3/4] rev-parse: update documentation of --flags and --no-flags options Jon Seymour
2010-09-25 13:33 ` [PATCH v4 4/4] rev-parse: make --flags imply --no-revs for remaining arguments Jon Seymour
2010-09-25 14:20 ` Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimj--jZdX++=ZjF3A0HE11FbkgVb2gs3ADVEGvx@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=jon.seymour@gmail.com \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).