From: Catalin Marinas <catalin.marinas@gmail.com>
To: Karl Wiberg <kha@treskal.com>
Cc: Chris Packham <judge.packham@gmail.com>, GIT <git@vger.kernel.org>
Subject: Re: making stgit handle being rebased by git rebase
Date: Thu, 11 Nov 2010 10:41:55 +0000 [thread overview]
Message-ID: <AANLkTimjO0yMJvf_fF3g7qypAuhPyiHCeF-sUv5toM_S@mail.gmail.com> (raw)
In-Reply-To: <AANLkTik_dFsaiDkugrpBp8T31zNWVMRNC=hQBj0RmV+o@mail.gmail.com>
On 11 November 2010 10:29, Karl Wiberg <kha@treskal.com> wrote:
> On Mon, Nov 8, 2010 at 11:39 PM, Chris Packham <judge.packham@gmail.com> wrote:
>> Has anyone looked at making stgit interact with git-rebase more gracefully?
>
> The problem is that StGit's metadata gets out of date when you do a
> git rebase. A solution would either have to change StGit's metadata
> representation so that it can't get out of date, or be a fancy version
> of repair/uncommit that can actually figure out what git did.
>
> I've thought a bit about this in the past, and the best solution I
> could come up with is of the first kind, and would change the
> representation of applied patches to use just two refs: the branch
> itself, and the stack base ref. I think git rebase wouldn't wreck
> things for that representation.
git rebase would most likely change the base of the stack so stgit can
no longer track its patches. If git rebase just moves the stack base
forward, stgit could generate additional patches that have been
brought in by git, though sometimes this would include merges etc.
Maybe a better option for stgit is to just remember the branch and the
number of patches (probably including the patch names unless we always
generate them automatically, not that bad but you lose the possibility
of renaming patches).
The above would work well if people use git commit on top of an stgit
branch. The patch names maybe be wrongly associated or (if we
automatically generate patch names) we may miss the first patch in the
series because of the number of commits. The latter is not that bad
since we can always use stg uncommit, though a stg rebase could
override the committed patch.
--
Catalin
next prev parent reply other threads:[~2010-11-11 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 22:39 making stgit handle being rebased by git rebase Chris Packham
2010-11-11 10:29 ` Karl Wiberg
2010-11-11 10:41 ` Catalin Marinas [this message]
2010-11-11 11:34 ` Karl Wiberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimjO0yMJvf_fF3g7qypAuhPyiHCeF-sUv5toM_S@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).