From: Thiago Farina <tfransosi@gmail.com>
To: Drew Northup <drew.northup@maine.edu>
Cc: "Vasyl'" <vvavrychuk@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] trace.c: mark file-local function static
Date: Mon, 20 Dec 2010 13:17:49 -0200 [thread overview]
Message-ID: <AANLkTimkxJHvTAvra+B-0bAQopd8s21ZrFCPG_ALbZZ9@mail.gmail.com> (raw)
In-Reply-To: <1292846433.19322.1.camel@drew-northup.unet.maine.edu>
On Mon, Dec 20, 2010 at 10:00 AM, Drew Northup <drew.northup@maine.edu> wrote:
>
> On Thu, 2010-12-16 at 21:43 -0200, Thiago Farina wrote:
>> On Thu, Dec 16, 2010 at 8:38 PM, Vasyl' <vvavrychuk@gmail.com> wrote:
>> > Signed-off-by: Vasyl' Vavrychuk <vvavrychuk@gmail.com>
>> > ---
>> > trace.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/trace.c b/trace.c
>> > index 1e560cb..62586fa 100644
>> > --- a/trace.c
>> > +++ b/trace.c
>> > @@ -25,7 +25,7 @@
>> > #include "cache.h"
>> > #include "quote.h"
>> >
>> > -void do_nothing(size_t unused)
>> > +static void do_nothing(size_t unused)
>> > {
>> > }
>> >
>> If it means something, this looks sane to me.
>>
>> Acked-by: Thiago Farina <tfransosi@gmail.com>
>
> It may be sane, but why should we trust that it is without a commit
> message?
Why such trivial thing needs further explanation?
next prev parent reply other threads:[~2010-12-20 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 22:38 [PATCH] trace.c: mark file-local function static Vasyl'
2010-12-16 23:43 ` Thiago Farina
2010-12-20 12:00 ` Drew Northup
2010-12-20 15:17 ` Thiago Farina [this message]
2010-12-20 16:53 ` Drew Northup
2010-12-21 0:28 ` Thiago Farina
2010-12-21 12:29 ` Drew Northup
2010-12-21 15:59 ` Thiago Farina
2010-12-21 14:52 ` Nguyen Thai Ngoc Duy
2010-12-21 15:19 ` Drew Northup
2010-12-21 17:24 ` Junio C Hamano
2010-12-21 17:40 ` Thiago Farina
2010-12-21 17:50 ` Junio C Hamano
2010-12-21 19:54 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimkxJHvTAvra+B-0bAQopd8s21ZrFCPG_ALbZZ9@mail.gmail.com \
--to=tfransosi@gmail.com \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
--cc=vvavrychuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).