From: Erik Faye-Lund <kusmabite@googlemail.com>
To: "Török Edwin" <edwintorok@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Fix 'git clean' failure on NFS.
Date: Fri, 18 Jun 2010 14:29:38 +0200 [thread overview]
Message-ID: <AANLkTimm1XMmDORpnezYHSNPrKFup2H5ODQLrgJivDwg@mail.gmail.com> (raw)
In-Reply-To: <1276859235-13534-1-git-send-email-edwintorok@gmail.com>
2010/6/18 Török Edwin <edwintorok@gmail.com>:
> readdir() used to do a single pass, which is not always enough.
> If you unlink some files/rmdir some subdirs then there might be some
> files you haven't seen yet *before* the readdir cursor (files get rearranged
> in the directory, etc.).
>
> The fix is to do an additional readdir() pass if we unlinked/rmdired something.
> This is easily accomplished by using rewinddir.
>
Won't this break on Windows? mingw_readdir() doesn't seem to have a
maching mingw_rewinddir() in compat/mingw.c/h....
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-06-18 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 14:26 [BUG] git clean not working on FreeBSD/NFS Török Edwin
2010-06-17 15:18 ` Henrik Grubbström
2010-06-18 11:03 ` Török Edwin
2010-06-18 11:07 ` [PATCH] Fix 'git clean' failure on NFS Török Edwin
2010-06-18 12:17 ` Johannes Sixt
2010-06-18 13:09 ` Török Edwin
2010-06-18 12:29 ` Erik Faye-Lund [this message]
2010-06-18 13:01 ` Török Edwin
2010-06-18 13:26 ` Erik Faye-Lund
2010-06-18 13:50 ` Török Edwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimm1XMmDORpnezYHSNPrKFup2H5ODQLrgJivDwg@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=edwintorok@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).