Re: [PATCH GSoC] gitweb: Add support for enabling 'write' feature

[Pavan Kumar Sunkara <pavan.sss1991@gmail.com>]

2010/6/22 Jakub Narebski <jnareb@gmail.com>:
> On Tue, 22 June 2010, Pavan Kumar Sunkara wrote:
>
>> Provide $feature{'write'} to enable the 'write'
>> functionalities for gitweb. While outputting HTML
>> it checks for gitweb_check_feature('write') and if
>> it's enabled, proper links will appear along with
>> the HTML divs.
>>
>> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
>> ---
>>  This patch is based on my previous patch series.
>>  http://mid.gmane.org/1277157648-6029-1-git-send-email-pavan.sss1991@gmail.com
>
> It looks a bit like this email is send by accident...
>
>>  And this is my first patch in the preparation for integration
>>  of write functionality into gitweb.
>>
>>  gitweb/lib/Gitweb/Config.pm |   11 +++++++++++
>>  1 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/gitweb/lib/Gitweb/Config.pm b/gitweb/lib/Gitweb/Config.pm
>> index c528595..87f0ba6 100644
>> --- a/gitweb/lib/Gitweb/Config.pm
>> +++ b/gitweb/lib/Gitweb/Config.pm
>> @@ -203,6 +203,17 @@ our %feature = (
>>       # (an array) or gitweb_check_feature(<feature>) to check if <feature>
>>       # is enabled
>>
>> +     # Enable the 'write' functionalities for gitweb. While outputting HTML
>> +     # it checks for gitweb_check_feature('write') and if it's enabled,
>> +     # proper links will appear along with the HTML divs.
>> +
>> +     # To enable system wide have in $GITWEB_CONFIG
>> +     # $feature{'write'}{'default'} = [1];
>> +     # Project specific override is not supported.
>> +     'write' => {
>> +             'override' => 0,
>> +             'default' => [0]},
>> +
>>       # Enable the 'blame' blob view, showing the last commit that modified
>>       # each line in the file. This can be very CPU-intensive.
>
> ...as there is nothing non-trivial in there.
>
> --
> Jakub Narebski
> Poland
>

But don't u think it would be like a small starting patch.

Thanks,
Pavan.