From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH av/i18n 2/2] Make git-sh-i18n executable
Date: Sun, 25 Jul 2010 10:19:34 +0000 [thread overview]
Message-ID: <AANLkTimpqw2RirLPDJkAhQIql793nwC9pc0HctIcxKKj@mail.gmail.com> (raw)
In-Reply-To: <d890d9ba7d967e6a191cb47194379d8f9ca5cd0d.1280051448.git.trast@student.ethz.ch>
On Sun, Jul 25, 2010 at 09:50, Thomas Rast <trast@student.ethz.ch> wrote:
> git-sh-i18n was not picked up by the valgrind wrapper code because
> that tests for the executable bit. Since there does not seem to be a
> particular reason why it needs to be non-executable, and this is the
> path of least special-casing to fix --valgrind testing, just make it
> executable.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
> 0 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 git-sh-i18n.sh
>
> diff --git a/git-sh-i18n.sh b/git-sh-i18n.sh
> old mode 100644
> new mode 100755
> --
Why is it including git-sh-i18n.sh? It should only be using the
generated SCRIPT_LIB git-sh-i18n file.
On my system the executable bit of git-sh-i18n.sh has no effect on the
generated git-sh-i18n file:
$ rm git-sh-i18n; chmod +x git-sh-i18n.sh ; make ; ls -l git-sh-i18n*
GEN git-sh-i18n
SUBDIR git-gui
SUBDIR gitk-git
make[1]: Nothing to be done for `all'.
SUBDIR perl
SUBDIR git_remote_helpers
SUBDIR templates
-rw-r--r-- 1 avar avar 1965 2010-07-25 10:15 git-sh-i18n
-rwxr-xr-x 1 avar avar 1955 2010-07-25 10:08 git-sh-i18n.sh
And this still leaves git-sh-setup without an executable bit, why
doesn't that fail under valgrind while git-sh-i18n apparently does?
Maybe something to do with it being included as
<<. "$GIT_EXEC_PATH"/git-sh-i18n>> instead of as <<. git-sh-setup>> ?
next prev parent reply other threads:[~2010-07-25 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 9:50 [PATCH av/i18n 1/2] tests: Symlink share and po into valgrind wrapper directory Thomas Rast
2010-07-25 9:50 ` [PATCH av/i18n 2/2] Make git-sh-i18n executable Thomas Rast
2010-07-25 10:19 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-25 13:15 ` Thomas Rast
2010-07-25 14:55 ` [PATCH ab/i18n v2] tests: locate i18n lib&data correctly under --valgrind Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimpqw2RirLPDJkAhQIql793nwC9pc0HctIcxKKj@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).