From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Spencer E. Olson" <olsonse@umich.edu>
Cc: git@vger.kernel.org, Nick Hengeveld <nickh@reactrix.com>,
Mark Lodato <lodatom@gmail.com>,
Tay Ray Chuan <rctay89@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH v2] Allow HTTP user agent string to be modified.
Date: Sat, 7 Aug 2010 17:39:38 +0000 [thread overview]
Message-ID: <AANLkTimsYJxvHZkj8DNyOLozA4HJ9cwo+v3G_r2UXWz-@mail.gmail.com> (raw)
In-Reply-To: <1281202184.4815.1.camel@compaq.olson.home>
On Sat, Aug 7, 2010 at 17:29, Spencer E. Olson <olsonse@umich.edu> wrote:
> I would have no problem doing that. I was just trying to match the
> style already present in http.c. All the other pointer tests in that
> function/file are done the same.
Ah, fair enough. I didn't notice that the rest of http.c already used
that style, nevermind then.
It's best to just keep it consistent, and maybe clean it up in some
later patch, but best not to introduce an inconsistency by using a
different style just for this one.
Your patch looks good.
next prev parent reply other threads:[~2010-08-07 17:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 3:34 [PATCH v2] Allow HTTP user agent string to be modified Spencer E. Olson
2010-08-07 8:34 ` Ævar Arnfjörð Bjarmason
2010-08-07 17:29 ` Spencer E. Olson
2010-08-07 17:39 ` Ævar Arnfjörð Bjarmason [this message]
2010-08-08 2:49 ` Tay Ray Chuan
2010-08-08 2:51 ` Tay Ray Chuan
2010-08-08 3:57 ` Spencer E. Olson
2010-08-11 5:24 ` [PATCH v3] " Spencer E. Olson
2010-08-11 8:04 ` Tay Ray Chuan
2010-08-11 20:08 ` Junio C Hamano
2010-08-11 20:32 ` [PATCH v4] " Spencer E. Olson
2010-08-11 20:35 ` Jacob Helwig
2010-08-11 20:40 ` [PATCH v5] " Spencer E. Olson
2010-08-12 17:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimsYJxvHZkj8DNyOLozA4HJ9cwo+v3G_r2UXWz-@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=lodatom@gmail.com \
--cc=nickh@reactrix.com \
--cc=olsonse@umich.edu \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).