From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Greg Brockman <gdb@mit.edu>,
kpfleming@digium.com, brlink@debian.org
Subject: Re: [PATCH] Cast execl*() NULL sentinels to (char *)
Date: Sat, 24 Jul 2010 15:27:37 +0000 [thread overview]
Message-ID: <AANLkTimxB-n4oq-5XUSK5XwEXLnwLsakyuryNlUnghJr@mail.gmail.com> (raw)
In-Reply-To: <00564b8ba93617801bb78b4a0ec67784e597d02a.1279983892.git.trast@student.ethz.ch>
On Sat, Jul 24, 2010 at 15:20, Thomas Rast <trast@student.ethz.ch> wrote:
> The NULL sentinel argument to the execl*() family of calls must be
> cast to (char *), as otherwise:
>
> - platforms where NULL is just 0 (not (void *)) would pass an int
>
> - (admittedly esoteric) platforms where NULL is (void *)0 and (void *)
> and (char *) have different memory layouts would pass the wrong kind
> of pointer
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Nice that you got around to this after I inadvertently pointed it out
in another thread.
Acked.
next prev parent reply other threads:[~2010-07-24 15:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 3:01 [PATCH/RFC 0/4] Providing mechanism to list available repositories Greg Brockman
2010-07-14 3:01 ` [PATCH/RFC 1/4] Allow creation of arbitrary git-shell commands Greg Brockman
2010-07-14 15:27 ` Junio C Hamano
2010-07-14 17:42 ` Greg Brockman
2010-07-14 3:01 ` [PATCH/RFC 2/4] git-shell-commands: Add a command to list bare repos Greg Brockman
2010-07-14 3:01 ` [PATCH/RFC 3/4] git-shell-commands: Add a help command Greg Brockman
2010-07-14 3:01 ` [PATCH/RFC 4/4] Add interactive mode to git-shell for user-friendliness Greg Brockman
2010-07-14 9:04 ` Ævar Arnfjörð Bjarmason
2010-07-14 13:59 ` Kevin P. Fleming
2010-07-14 15:24 ` Bernhard R. Link
2010-07-14 15:40 ` Thomas Rast
[not found] ` <20100714160730.GA27078@pcpool00.mathematik.uni-freiburg.de>
[not found] ` <AANLkTikEjMeKPkyY4RdRq-ESkmmq4PvqCFPgp8yvLVBz@mail.gmail.com>
2010-07-17 4:12 ` Greg Brockman
2010-07-17 5:52 ` Jonathan Nieder
2010-07-17 14:53 ` Greg Brockman
2010-07-24 15:20 ` [PATCH] Cast execl*() NULL sentinels to (char *) Thomas Rast
2010-07-24 15:27 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-14 10:27 ` [PATCH/RFC 4/4] Add interactive mode to git-shell for user-friendliness Johannes Sixt
2010-07-14 19:11 ` [PATCH/RFC 0/4] Providing mechanism to list available repositories Junio C Hamano
2010-07-14 19:29 ` Greg Brockman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimxB-n4oq-5XUSK5XwEXLnwLsakyuryNlUnghJr@mail.gmail.com \
--to=avarab@gmail.com \
--cc=brlink@debian.org \
--cc=gdb@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kpfleming@digium.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).