From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: Re: Rename/copy detection - options/display improvement proposition
Date: Thu, 3 Mar 2011 16:54:23 +0100 [thread overview]
Message-ID: <AANLkTin0BJFc1a9SHbou1b=aZA+ta50MAFbFZWYTc8ka@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimbvWLCxf6HM-f_z30uUE-Nbpf-tcNzd8GbgK2C@mail.gmail.com>
On Thu, Mar 3, 2011 at 4:49 PM, Piotr Krukowiecki
<piotr.krukowiecki@gmail.com> wrote:
> Hi,
>
> I think that:
>
> 1. git-status should accept -M<n> -C<n>, same as git-diff
> 2. git-diff should have an option to omit diff for deleted files
>
>
> 1. git-status incorrectly recognizes some changes as copied, e.g.:
>
> # Changes to be committed:
> # copied: SimpleMatcher.h -> BSlashMatcher.h
> # copied: SimpleMatcher.h -> StringMatcher.h
> # renamed: SimpleMatcher.h -> TabMatcher.h
>
> (generally SimpleMatcher.h is recognized as being copied into many
> different headers)
>
> git-diff shows similarity index 50-60%.
> git-diff -M80 -C80 correctly stops recognizing this as copies/renames.
>
> I think git-status also should learn -M and -C, as it works the same
> way as git-diff with defaults.
>
>
> 2. git-diff does not show diff for copied files. But when a files is
> removed, the diff is shown.
>
> I think seeing what was deleted is sometimes useful, but sometimes it
> is not and just clutters the
> diff.
I have committed the changes and git-commit, git-log--stat output also
shows the renames - so I suppose this is a global issue
--
Piotrek
prev parent reply other threads:[~2011-03-03 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 15:49 Rename/copy detection - options/display improvement proposition Piotr Krukowiecki
2011-03-03 15:54 ` Piotr Krukowiecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin0BJFc1a9SHbou1b=aZA+ta50MAFbFZWYTc8ka@mail.gmail.com' \
--to=piotr.krukowiecki@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).