From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Daniel F <nanotube@gmail.com>
Cc: Jay Soffian <jaysoffian@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: git am mangles commit author name.
Date: Tue, 13 Jul 2010 22:16:40 +0000 [thread overview]
Message-ID: <AANLkTin0UtjqOIpbEwu9YTCtt2A_QNiWExu-ov13DVfd@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimCjfFh25vbzotufpTnUjfRglzHiQeDzWz8O5RJ@mail.gmail.com>
On Tue, Jul 13, 2010 at 15:48, Daniel F <nanotube@gmail.com> wrote:
> Ah yes, indeed... Well, is there any reason to even have that
> length sanity check in the first place? If someone wants to be
> identified with a nick of 1 or 2 chars, what's wrong with that?
I don't know. The whole thing seems a bit silly. I changed it:
- if (name->len < 3 || 60 < name->len || strchr(name->buf, '@')
||
+ if (name->len < 1 || 60 < name->len ||
strchr(name->buf, '@') ||
And nothing in the test suite broke. Removing the `name->len <' clause
completely broke one test in t5100-mailinfo.sh however.
But I don't understand that part of Git, maybe it really will break
horribly somewhere with:
Author: av <a@v.net>
next prev parent reply other threads:[~2010-07-13 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 3:53 git am mangles commit author name Daniel F
2010-07-13 5:49 ` Jonathan Nieder
2010-07-13 14:54 ` Daniel F
2010-07-13 15:11 ` Jay Soffian
2010-07-13 15:48 ` Daniel F
2010-07-13 22:16 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-14 14:16 ` Tor Arntsen
2010-07-14 14:31 ` Ævar Arnfjörð Bjarmason
2010-07-16 14:18 ` Daniel F
2010-07-16 19:19 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin0UtjqOIpbEwu9YTCtt2A_QNiWExu-ov13DVfd@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=jrnieder@gmail.com \
--cc=nanotube@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).