From: Pascal Obry <pascal@obry.net>
To: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] Do not decode url protocol.
Date: Tue, 22 Jun 2010 11:22:47 +0200 [thread overview]
Message-ID: <AANLkTin2WIBHAt3dK9NoYwSXR9ZVO_3mWdt-dsSIygvf@mail.gmail.com> (raw)
When using the protocol git+ssh:// for example we do not want to
decode the '+' as a space.
This fixes a regression introduced in 9d2e942.
---
url.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/url.c b/url.c
index cd32b92..ba0c1ac 100644
--- a/url.c
+++ b/url.c
@@ -70,9 +70,18 @@ static int url_decode_char(const char *q)
static char *url_decode_internal(const char **query, const char *stop_at)
{
const char *q = *query;
+ const char *first_slash;
struct strbuf out;
strbuf_init(&out, 16);
+
+ /* Skip protocol */
+ first_slash = strchr(*query, '/');
+
+ while (q < first_slash) {
+ strbuf_addch(&out, *q++);
+ }
+
do {
unsigned char c = *q;
--
1.7.1.524.g6df2f
--
--|------------------------------------------------------
--| Pascal Obry Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--| http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595
next reply other threads:[~2010-06-22 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 9:22 Pascal Obry [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-22 9:25 [PATCH] Do not decode url protocol Pascal Obry
2010-06-22 11:22 ` Matthieu Moy
2010-06-22 11:34 ` Matthieu Moy
2010-06-22 11:46 ` Pascal Obry
2010-06-23 23:54 ` René Scharfe
2010-06-29 16:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin2WIBHAt3dK9NoYwSXR9ZVO_3mWdt-dsSIygvf@mail.gmail.com \
--to=pascal@obry.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).