From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] grep: Don't pass a TODO test if REG_STARTEND is supported
Date: Thu, 15 Jul 2010 15:32:57 +0000 [thread overview]
Message-ID: <AANLkTin5a39MQurIdXYu-SZVLhNTefbyZmJALT5SrdQF@mail.gmail.com> (raw)
In-Reply-To: <4C364A0B.2020909@lsrfire.ath.cx>
On Thu, Jul 8, 2010 at 21:58, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
> In this particular case the tested functionality is not provided accross
> all platforms supported by git. It would be better to fix the actual
> issue, namely that the fallback regex lib we provide doesn't support
> REG_STARTEND.
We're currently providing the GNU regex library, it seems Mac OS X and
FreeBSD ship with a regex library that has REG_STARTEND (according to
`git log --reverse compat/regex` the current library was added because
of incompatibilities on OSX, but those were since fixed in
310e0216c8).
If the FreeBSD and Mac OS X implementations are good enough we could
just swap the GNU one for the FreeBSD one
(http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/regex/). Is there
any reason not to do this, or would a different regex library be a
better fit?
next prev parent reply other threads:[~2010-07-15 15:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 0:42 [PATCH] grep: Don't pass a TODO test if REG_STARTEND is supported Ævar Arnfjörð Bjarmason
2010-07-08 19:40 ` Junio C Hamano
2010-07-08 20:09 ` Ævar Arnfjörð Bjarmason
2010-07-08 21:58 ` René Scharfe
2010-07-15 15:32 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-15 17:47 ` Junio C Hamano
2010-07-15 18:44 ` Ævar Arnfjörð Bjarmason
[not found] ` <20100715220059.GA3312@burratino>
2010-07-16 13:58 ` [RFC/PATCH] Update compat/regex Ævar Arnfjörð Bjarmason
2010-07-16 14:17 ` Andreas Schwab
2010-08-15 11:08 ` Ævar Arnfjörð Bjarmason
2010-08-16 12:26 ` Paolo Bonzini
2010-08-17 3:25 ` [PATCH/RFC 0/3] " Ævar Arnfjörð Bjarmason
2010-08-17 3:25 ` [PATCH/RFC 2/3] compat/regex: hacks to get the gawk regex engine to compile within git Ævar Arnfjörð Bjarmason
2010-08-17 3:35 ` Jonathan Nieder
2010-08-17 3:25 ` [PATCH/RFC 3/3] t/t7008-grep-binary.sh: un-TODO a test that needs REG_STARTEND Ævar Arnfjörð Bjarmason
[not found] ` <1282015548-19074-2-git-send-email-avarab@gmail.com>
2010-08-17 3:37 ` [PATCH/RFC 1/3] compat/regex: use the regex engine from gawk for compat Jonathan Nieder
2010-08-17 3:50 ` Ævar Arnfjörð Bjarmason
2010-08-17 4:08 ` Jonathan Nieder
2010-08-17 5:17 ` [PATCH/RFC v2 0/3] Update compat/regex Ævar Arnfjörð Bjarmason
2010-08-17 8:03 ` Jonathan Nieder
2010-08-17 9:24 ` [PATCH 0/5] " Ævar Arnfjörð Bjarmason
2010-08-17 11:46 ` Paolo Bonzini
2010-08-17 23:19 ` Junio C Hamano
2010-08-17 23:50 ` Jonathan Nieder
2010-08-18 10:41 ` Ævar Arnfjörð Bjarmason
2010-08-17 9:24 ` [PATCH 2/5] compat/regex: get the gawk regex engine to compile within git Ævar Arnfjörð Bjarmason
2010-08-17 9:24 ` [PATCH 3/5] Change regerror() declaration from K&R style to ANSI C (C89) Ævar Arnfjörð Bjarmason
2010-08-17 9:24 ` [PATCH 4/5] t/t7008-grep-binary.sh: un-TODO a test that needs REG_STARTEND Ævar Arnfjörð Bjarmason
2010-08-17 9:24 ` [PATCH 5/5] autoconf: don't use platform regex if it lacks REG_STARTEND Ævar Arnfjörð Bjarmason
2010-08-17 5:17 ` [PATCH/RFC v2 2/3] compat/regex: get the gawk regex engine to compile within git Ævar Arnfjörð Bjarmason
2010-08-17 5:17 ` [PATCH/RFC v2 3/3] t/t7008-grep-binary.sh: un-TODO a test that needs REG_STARTEND Ævar Arnfjörð Bjarmason
2010-07-16 14:33 ` [PATCH] grep: Don't pass a TODO test if REG_STARTEND is supported Ævar Arnfjörð Bjarmason
2010-07-16 19:50 ` Jonathan Nieder
2010-07-16 20:51 ` Ævar Arnfjörð Bjarmason
2010-07-16 21:06 ` Jonathan Nieder
2010-07-16 21:19 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin5a39MQurIdXYu-SZVLhNTefbyZmJALT5SrdQF@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).