From: Erik Faye-Lund <kusmabite@gmail.com>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v6 00/16] daemon-win32
Date: Wed, 3 Nov 2010 23:39:34 +0100 [thread overview]
Message-ID: <AANLkTin6120QbxyxHt=UM9Dpk_3C-vaD2z8RaRuut76r@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin2BCxDoKhDCSgSRG1eVUGVeQh6Bq_=FfAe0M_M@mail.gmail.com>
On Wed, Nov 3, 2010 at 11:18 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> Ah, thanks. For me it's leaking a variable amount of handles per
> ls-remote, but if I apply the following patch it's down to one. Need
> to find that one as well...
>
> diff --git a/compat/mingw.c b/compat/mingw.c
> index b780200..47e7d26 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -1519,8 +1519,10 @@ pid_t waitpid(pid_t pid, int *status, unsigned options)
> }
>
> if (pid > 0 && options & WNOHANG) {
> - if (WAIT_OBJECT_0 != WaitForSingleObject((HANDLE)pid, 0))
> + if (WAIT_OBJECT_0 != WaitForSingleObject((HANDLE)pid, 0)) {
AAAND the last one is right here as well:
- if (WAIT_OBJECT_0 != WaitForSingleObject((HANDLE)pid, 0))
+ if (WAIT_OBJECT_0 != WaitForSingleObject(h, 0)) {
next prev parent reply other threads:[~2010-11-03 22:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 16:31 [PATCH v6 00/16] daemon-win32 Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 01/16] mingw: add network-wrappers for daemon Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 02/16] mingw: implement syslog Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 03/16] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 04/16] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 05/16] mingw: use real pid Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 06/16] mingw: support waitpid with pid > 0 and WNOHANG Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 07/16] mingw: add kill emulation Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 08/16] daemon: use run-command api for async serving Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 09/16] daemon: use full buffered mode for stderr Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 10/16] Improve the mingw getaddrinfo stub to handle more use cases Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 11/16] daemon: get remote host address from root-process Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 12/16] mingw: import poll-emulation from gnulib Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 13/16] mingw: use " Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 14/16] daemon: use socklen_t Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 15/16] daemon: make --inetd and --detach incompatible Erik Faye-Lund
2010-11-03 16:31 ` [PATCH v6 16/16] daemon: opt-out on features that require posix Erik Faye-Lund
2010-11-03 21:11 ` [PATCH v6 00/16] daemon-win32 Pat Thoyts
2010-11-03 22:18 ` Erik Faye-Lund
2010-11-03 22:39 ` Erik Faye-Lund [this message]
2010-11-04 0:28 ` Pat Thoyts
2010-11-04 0:53 ` Erik Faye-Lund
2010-11-04 1:04 ` Pat Thoyts
2010-11-03 22:58 ` Erik Faye-Lund
2010-11-04 0:06 ` Erik Faye-Lund
2010-11-04 0:28 ` Erik Faye-Lund
2010-11-04 8:58 ` Martin Storsjö
2010-11-04 9:15 ` Erik Faye-Lund
2010-11-04 9:35 ` Martin Storsjö
2010-11-04 10:15 ` Erik Faye-Lund
2010-11-04 8:52 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTin6120QbxyxHt=UM9Dpk_3C-vaD2z8RaRuut76r@mail.gmail.com' \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).