From: Sverre Rabbelier <srabbelier@gmail.com>
To: Simo Melenius <simo.melenius@iki.fi>
Cc: jrnieder@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH 2/2] branch: don't fail listing branches if one of the commits wasn't found
Date: Thu, 3 Jun 2010 19:42:01 +0200 [thread overview]
Message-ID: <AANLkTinD2OLZllialwyAwuEroCDo9w56Zu_3bhKbf-gg@mail.gmail.com> (raw)
In-Reply-To: <1275551282-21557-2-git-send-email-simo.melenius@iki.fi>
Heya,
On Thu, Jun 3, 2010 at 09:48, Simo Melenius <simo.melenius@iki.fi> wrote:
> + if (cb.ret)
> + error("some refs could not be read, review stderr");
I don't think there's any precedence for an error message like this,
perhaps in git-svn's "the above error message is nothing to worry
about, move along", which I think is silly as well. I think it's best
to just s/, review stderr// here.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-06-03 17:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 14:47 Bug? "git branch" failing to list all branches Simo Melenius
2010-06-03 4:22 ` Jonathan Nieder
2010-06-03 6:00 ` Simo Melenius
2010-06-03 6:55 ` Jonathan Nieder
2010-06-03 7:48 ` [PATCH 1/2] branch: exit status now reflects if branch listing finds an error Simo Melenius
2010-06-04 2:24 ` Jonathan Nieder
2010-06-03 7:48 ` [PATCH 2/2] branch: don't fail listing branches if one of the commits wasn't found Simo Melenius
2010-06-03 17:42 ` Sverre Rabbelier [this message]
2010-06-04 2:43 ` Jonathan Nieder
2010-06-04 9:48 ` Simo Melenius
2010-06-04 9:50 ` [PATCH 1/2] branch: exit status now reflects if branch listing finds an error Simo Melenius
2010-06-04 9:50 ` [PATCH 2/2] branch: don't fail listing branches if one of the commits wasn't found Simo Melenius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinD2OLZllialwyAwuEroCDo9w56Zu_3bhKbf-gg@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=simo.melenius@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).