git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] logging branch deletion to help recovering from mistakes
Date: Tue, 7 Dec 2010 18:37:01 +0700	[thread overview]
Message-ID: <AANLkTinDyix3KEdLLGJEWQ8X+a3zQZOAiTh2mLf5wuvQ@mail.gmail.com> (raw)
In-Reply-To: <7vmxoiqeoq.fsf@alter.siamese.dyndns.org>

On Tue, Dec 7, 2010 at 1:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> On Tue, Dec 7, 2010 at 4:16 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> +#define BRANCH_DELETION_LOG "DELETED-REFS"
>>> +
>>
>> Should this special log be mentioned in git-update-ref.txt or
>> gitrepository-layout.txt?
>
> Perhaps, but I wasn't sure if this patch itself is a good idea to begin
> with.  Not the problem it tries to solve, but its approach.
>
> For example, this cannot be shown with "reflog show" or "log -g" due to
> the way these frontends locate the reflog file to read (the logic wants to
> have an underlying ref).
>

I think you have thought of this. What's wrong with keeping reflog
when a branch is removed and appending "delete" line to the said
reflog? I don't know how reflogs are managed, but those reflogs
without associated branch will (or should) be cleaned when they are
expired.

I stick with this idea because I also want to archive old branches and
am thinking those reflogs ending with "archive" line will be kept
forever, or until I feel like digging up them again.
-- 
Duy

  reply	other threads:[~2010-12-07 11:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 21:16 [PATCH] logging branch deletion to help recovering from mistakes Junio C Hamano
2010-12-06 21:55 ` Štěpán Němec
2010-12-06 23:14 ` Andreas Schwab
2010-12-07  1:18 ` Nguyen Thai Ngoc Duy
2010-12-07  6:28   ` Junio C Hamano
2010-12-07 11:37     ` Nguyen Thai Ngoc Duy [this message]
2010-12-07 15:25       ` Michael J Gruber
2010-12-07 16:25         ` Nguyen Thai Ngoc Duy
2010-12-07 16:22       ` Jakub Narebski
2010-12-07 16:26         ` Nguyen Thai Ngoc Duy
2010-12-07 17:06     ` Jeff King
2010-12-07 18:14       ` Shawn Pearce
2010-12-07 18:20         ` Jeff King
2010-12-07 18:23           ` Shawn O. Pearce
2010-12-07 18:35             ` Jeff King
2010-12-07 18:37               ` Shawn O. Pearce
2010-12-07 18:39                 ` Jeff King
2010-12-07 18:41                   ` Shawn O. Pearce
2010-12-07 19:21       ` Junio C Hamano
2010-12-07 19:38         ` Jeff King
2010-12-07 16:23 ` Casey Dahlin
2010-12-07 17:45   ` Jonathan Nieder
2010-12-07 17:54     ` Casey Dahlin
2010-12-07 18:02       ` Jonathan Nieder
2010-12-07 18:26         ` Casey Dahlin
2010-12-07 20:25         ` Junio C Hamano
2010-12-07 20:55           ` Jonathan Nieder
2010-12-07 18:12       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinDyix3KEdLLGJEWQ8X+a3zQZOAiTh2mLf5wuvQ@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).