* Patchbombing or not, that is the question
@ 2010-11-27 17:18 Giuseppe Bilotta
2010-11-27 17:27 ` Jonathan Nieder
0 siblings, 1 reply; 6+ messages in thread
From: Giuseppe Bilotta @ 2010-11-27 17:18 UTC (permalink / raw)
To: Git List
Hello all,
I prepared a bunch of patches to add support to some other browsers to
git-web--browse (opera, seamonkey, elinks). Currently I did one patch
per browser. Should I squash them all together? (The series will also
contain some other patches that will stay separate.)
--
Giuseppe "Oblomov" Bilotta
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchbombing or not, that is the question
2010-11-27 17:18 Patchbombing or not, that is the question Giuseppe Bilotta
@ 2010-11-27 17:27 ` Jonathan Nieder
2010-11-27 17:40 ` Thiago Farina
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Nieder @ 2010-11-27 17:27 UTC (permalink / raw)
To: Giuseppe Bilotta; +Cc: Git List
Giuseppe Bilotta wrote:
> I prepared a bunch of patches to add support to some other browsers to
> git-web--browse (opera, seamonkey, elinks). Currently I did one patch
> per browser. Should I squash them all together?
Yeah, I'd squash them. (But I think either way would be fine.)
Could you support
[browser "chromium-browser"]
cmd=chromium-browser
while at it? :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchbombing or not, that is the question
2010-11-27 17:27 ` Jonathan Nieder
@ 2010-11-27 17:40 ` Thiago Farina
2010-11-27 18:13 ` Giuseppe Bilotta
0 siblings, 1 reply; 6+ messages in thread
From: Thiago Farina @ 2010-11-27 17:40 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Giuseppe Bilotta, Git List
On Sat, Nov 27, 2010 at 3:27 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Giuseppe Bilotta wrote:
>
>> I prepared a bunch of patches to add support to some other browsers to
>> git-web--browse (opera, seamonkey, elinks). Currently I did one patch
>> per browser. Should I squash them all together?
>
> Yeah, I'd squash them. (But I think either way would be fine.)
>
> Could you support
>
> [browser "chromium-browser"]
> cmd=chromium-browser
>
Yeah, that would be great!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchbombing or not, that is the question
2010-11-27 17:40 ` Thiago Farina
@ 2010-11-27 18:13 ` Giuseppe Bilotta
2010-11-27 18:34 ` Jonathan Nieder
0 siblings, 1 reply; 6+ messages in thread
From: Giuseppe Bilotta @ 2010-11-27 18:13 UTC (permalink / raw)
To: Thiago Farina; +Cc: Jonathan Nieder, Git List
On Sat, Nov 27, 2010 at 6:40 PM, Thiago Farina <tfransosi@gmail.com> wrote:
> On Sat, Nov 27, 2010 at 3:27 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Giuseppe Bilotta wrote:
>>
>>> I prepared a bunch of patches to add support to some other browsers to
>>> git-web--browse (opera, seamonkey, elinks). Currently I did one patch
>>> per browser. Should I squash them all together?
>>
>> Yeah, I'd squash them. (But I think either way would be fine.)
>>
>> Could you support
>>
>> [browser "chromium-browser"]
>> cmd=chromium-browser
>>
> Yeah, that would be great!
Actually I think that in this case the 'chromimu' configuration should
look for chromium-browser if chromium is not found.
--
Giuseppe "Oblomov" Bilotta
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchbombing or not, that is the question
2010-11-27 18:13 ` Giuseppe Bilotta
@ 2010-11-27 18:34 ` Jonathan Nieder
2010-11-27 18:39 ` Giuseppe Bilotta
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Nieder @ 2010-11-27 18:34 UTC (permalink / raw)
To: Giuseppe Bilotta; +Cc: Thiago Farina, Git List
Giuseppe Bilotta wrote:
> Actually I think that in this case the 'chromimu' configuration should
> look for chromium-browser if chromium is not found.
Even better might be to go straight for chromium-browser, to avoid
confusion with ancient versions of chromium-bsu.
Anyway, I hadn't noticed the new support for chromium. Thanks for
pointing it out.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchbombing or not, that is the question
2010-11-27 18:34 ` Jonathan Nieder
@ 2010-11-27 18:39 ` Giuseppe Bilotta
0 siblings, 0 replies; 6+ messages in thread
From: Giuseppe Bilotta @ 2010-11-27 18:39 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Thiago Farina, Git List
On Sat, Nov 27, 2010 at 7:34 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Giuseppe Bilotta wrote:
>
>> Actually I think that in this case the 'chromimu' configuration should
>> look for chromium-browser if chromium is not found.
>
> Even better might be to go straight for chromium-browser, to avoid
> confusion with ancient versions of chromium-bsu.
More precisely, we should look for chromium-browser first, and if not
found then use chromium. The fall-back to chromium is, I think, needed
because I suspect the binary was renamed in Debian only. Can somebody
with some other distribution confirm that chromium is called chromium
there?
--
Giuseppe "Oblomov" Bilotta
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-27 18:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-27 17:18 Patchbombing or not, that is the question Giuseppe Bilotta
2010-11-27 17:27 ` Jonathan Nieder
2010-11-27 17:40 ` Thiago Farina
2010-11-27 18:13 ` Giuseppe Bilotta
2010-11-27 18:34 ` Jonathan Nieder
2010-11-27 18:39 ` Giuseppe Bilotta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).