From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Peter Krefting <peter@softwolves.pp.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Command names should not be translated.
Date: Sun, 12 Sep 2010 22:51:54 +0000 [thread overview]
Message-ID: <AANLkTinN_fDAVVuT1ygCe7gMpHqAhL4GGjrZ98igbbP3@mail.gmail.com> (raw)
In-Reply-To: <20100912202105.DA51D2FC00@perkele>
On Sun, Sep 12, 2010 at 20:09, Peter Krefting <peter@softwolves.pp.se> wrote:
First off, thanks for contributing to this.
> - t = init_notes_check(N_("list"));
> + t = init_notes_check("list");
> - t = init_notes_check(N_("add"));
> + t = init_notes_check("add");
> - t = init_notes_check(N_("copy"));
> + t = init_notes_check("copy");
> - t = init_notes_check(N_("show"));
> + t = init_notes_check("show");
> - t = init_notes_check(N_("remove"));
> + t = init_notes_check("remove");
> - t = init_notes_check(N_("prune"));
> + t = init_notes_check("prune");
I disagree with all those. These don't end up being used in a context like:
die("git-%s: error ...", command);
But:
die(_("Refusing to %s notes in %s (outside of refs/notes/)"),
_(subcommand), t->ref);
I.e. here the git notes command name should be translated as a verb in
the native language (or not, that's up to the translator). E.g. I'd
translate that as:
add: Neita að bæta við
copy: Neita að afrita
etc. into Icelandic. Other languages will probably also want to
translate that.
> prune_notes(t, (verbose ? NOTES_PRUNE_VERBOSE : 0) |
> (show_only ? NOTES_PRUNE_VERBOSE|NOTES_PRUNE_DRYRUN : 0) );
> diff --git a/wt-status.c b/wt-status.c
> index f6946e1..7d4719f 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -663,9 +663,9 @@ void wt_status_print(struct wt_status *s)
> wt_status_print_submodule_summary(s, 1); /* unstaged */
> }
> if (s->show_untracked_files) {
> - wt_status_print_other(s, &s->untracked, _("Untracked"), _("add"));
> + wt_status_print_other(s, &s->untracked, _("Untracked"), "add");
> if (s->show_ignored_files)
> - wt_status_print_other(s, &s->ignored, _("Ignored"), _("add -f"));
> + wt_status_print_other(s, &s->ignored, _("Ignored"), "add -f");
> } else if (s->commitable)
> fprintf(s->fp, _("# Untracked files not listed%s\n"),
> advice_status_hints
These however are good, because here it gets used as:
color_fprintf_ln(s->fp, c, _("# (use \"git %s <file>...\" to
include in what will be committed)"), how);
I.e. this is purely a hardcoded command name.
next prev parent reply other threads:[~2010-09-12 22:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 20:09 [PATCH 1/2] Command names should not be translated Peter Krefting
2010-09-12 22:51 ` Ævar Arnfjörð Bjarmason [this message]
2010-09-13 5:07 ` Peter Krefting
-- strict thread matches above, loose matches on Subject: below --
2010-09-20 8:00 Peter Krefting
2010-09-20 10:22 ` Ævar Arnfjörð Bjarmason
2010-09-20 11:32 ` Peter Krefting
2010-09-20 11:37 ` Ævar Arnfjörð Bjarmason
2010-09-21 7:12 ` Peter Krefting
2010-09-20 8:00 Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinN_fDAVVuT1ygCe7gMpHqAhL4GGjrZ98igbbP3@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peter@softwolves.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).