From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] init, clone: support --real-git-dir for .git file
Date: Fri, 4 Mar 2011 19:09:21 +0100 [thread overview]
Message-ID: <AANLkTinQCZXYAbndLuRVVEr6NTRA8aaypFfvtqNjknLQ@mail.gmail.com> (raw)
In-Reply-To: <AANLkTiksQg1U=uAEVJG8fyjd7HpsTqgBOdyh6wrEMSED@mail.gmail.com>
On Fri, Mar 4, 2011 at 1:26 PM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:
> 2011/3/4 Piotr Krukowiecki <piotr.krukowiecki@gmail.com>:
>> I thought it was user-level file, like $GIT_DIR
>>
>> I'm not into data duplication, but in this case the message is next to the
>> previous use:
>>
>> if (prefixcmp(buf, "gitdir: "))
>> die("Invalid gitfile format: %s\nUse gitdir: <PATH>", path);
>>
>>
>> BTW I think it might be enough to have just path in the .git file. If
>> .git has path
>> to a correct git repo then chances it's coincidence are quite low.
>> (The format does not matter if it's internal file of course)
>
> It's actually good that path is prefixed by gitdir. I imagine once
> superproject is supported, .git file in subprojects will have another
> line
>
> supergitdir: /path/to/superproject
Why would it be better than keeping this information under .git/, in config
or other specific file?
--
Piotrek
next prev parent reply other threads:[~2011-03-04 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 12:43 [PATCH/RFC] init, clone: support --real-git-dir for .git file Nguyễn Thái Ngọc Duy
2011-03-03 21:13 ` Piotr Krukowiecki
2011-03-03 23:31 ` Junio C Hamano
2011-03-04 7:41 ` Piotr Krukowiecki
2011-03-04 12:26 ` Nguyen Thai Ngoc Duy
2011-03-04 18:09 ` Piotr Krukowiecki [this message]
2011-03-04 18:41 ` Junio C Hamano
2011-03-04 4:19 ` Nguyen Thai Ngoc Duy
2011-03-04 0:08 ` Junio C Hamano
2011-03-04 4:13 ` Miles Bader
2011-03-04 4:33 ` Nguyen Thai Ngoc Duy
2011-03-04 4:23 ` Nguyen Thai Ngoc Duy
2011-03-04 6:00 ` Junio C Hamano
2011-03-04 6:39 ` Nguyen Thai Ngoc Duy
2011-03-04 6:57 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinQCZXYAbndLuRVVEr6NTRA8aaypFfvtqNjknLQ@mail.gmail.com \
--to=piotr.krukowiecki@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).