From: Sitaram Chamarty <sitaramc@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ilari Liusvaara" <ilari.liusvaara@elisanet.fi>,
"Jonathan Nieder" <jrnieder@gmail.com>,
git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
"Tarmigan Casebolt" <tarmigan+git@gmail.com>
Subject: Re: [PATCH] Add ERR support to smart HTTP
Date: Mon, 6 Sep 2010 11:15:57 +0530 [thread overview]
Message-ID: <AANLkTinTFWHWU1vCnDa-c3p5g+y7wnH9A8fieowQHU5z@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikGiekZGNffaraHK-waBt7wH84jujM_uh3cw46y@mail.gmail.com>
On Mon, Sep 6, 2010 at 6:34 AM, Sitaram Chamarty <sitaramc@gmail.com> wrote:
> On Mon, Sep 6, 2010 at 2:52 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> On Sun, Sep 5, 2010 at 18:49, Ilari Liusvaara
>>> <ilari.liusvaara@elisanet.fi> wrote:
>>>
>>> > AFAIK, HTTP errors don't have descriptions printed.
>>>
>>> I don't know if this applies here but HTTP error codes can come with
>>> any free-form \n-delimited string:
>>>
>>> HTTP/1.1 402 You Must Build Additional Pylons
>>
>> And you can also send more detailed description in the *body* (and not
>> only HTTP headers) of HTTP response, though I don't know if git does
>> that.
turns out all this was moot. It was *because* I was using something
other than "200 OK" that the user was not seeing the message. Ilari's
patch just makes the message *look* better/cleaner, but I still have
to send it out with a "200 OK" status.
That was... a surprise :-)
Thanks all
sitaram
next prev parent reply other threads:[~2010-09-06 5:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 17:30 [PATCH] Add ERR support to smart HTTP Ilari Liusvaara
2010-09-05 17:41 ` Jonathan Nieder
2010-09-05 18:49 ` Ilari Liusvaara
2010-09-05 19:27 ` Ævar Arnfjörð Bjarmason
2010-09-05 21:21 ` Ilari Liusvaara
2010-09-05 21:22 ` Jakub Narebski
2010-09-06 1:04 ` Sitaram Chamarty
2010-09-06 5:45 ` Sitaram Chamarty [this message]
2010-09-06 8:45 ` Ævar Arnfjörð Bjarmason
2010-09-06 8:49 ` Jakub Narebski
2010-09-06 9:15 ` Joshua Juran
2010-09-06 14:56 ` Shawn O. Pearce
2010-09-06 17:59 ` Sitaram Chamarty
2010-09-06 18:19 ` Shawn O. Pearce
2010-09-08 14:36 ` Sitaram Chamarty
2010-09-06 14:24 ` Sitaram Chamarty
2010-09-06 16:31 ` Jakub Narebski
2010-09-05 20:11 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinTFWHWU1vCnDa-c3p5g+y7wnH9A8fieowQHU5z@mail.gmail.com \
--to=sitaramc@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=spearce@spearce.org \
--cc=tarmigan+git@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).