From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Fix expected values of setup tests on Windows
Date: Sat, 1 Jan 2011 10:46:54 +0700 [thread overview]
Message-ID: <AANLkTinWdGDtxPk24OBQnJP8fdHW9gYNDn46YKRGTWoB@mail.gmail.com> (raw)
In-Reply-To: <201012311711.06989.j6t@kdbg.org>
On Fri, Dec 31, 2010 at 11:11 PM, Johannes Sixt <j6t@kdbg.org> wrote:
>> in your patch does not. Does bash auto convert value in
>> TRASH_DIRECTORY="$TE..." line?
>
> No. When this line is executed:
>
> TEST_DIRECTORY=$(pwd)
>
> $(pwd) still has its default behavior to return the POSIX style path. pwd is
> redefined to pwd -W only later.
>
> I'm hesitant to redefine pwd earlier in test-lib.sh, though, because we would
> have to audit all uses of TEST_DIRECTORY for whether POSIX style paths or
> drive-letter paths are needed.
Ah I missed that. Thanks. Ack from me.
--
Duy
prev parent reply other threads:[~2011-01-01 3:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201012302205.13728.j6t@kdbg.org>
2010-12-31 13:00 ` [PATCH] Fix expected values of setup tests on Windows Nguyen Thai Ngoc Duy
2010-12-31 16:11 ` Johannes Sixt
2010-12-31 20:30 ` Jonathan Nieder
2010-12-31 22:21 ` Johannes Sixt
2011-01-02 1:31 ` Junio C Hamano
[not found] ` <4D2C09D7.3070700@viscovery.net>
2011-01-11 7:44 ` [PATCH 2/2] t/README: hint about using $(pwd) rather than $PWD in tests Johannes Sixt
2011-01-11 7:54 ` Jonathan Nieder
2011-01-11 8:15 ` Johannes Sixt
2011-01-11 8:37 ` Jonathan Nieder
2011-01-11 8:54 ` Johannes Sixt
2011-01-11 17:47 ` Junio C Hamano
2011-01-01 3:46 ` Nguyen Thai Ngoc Duy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinWdGDtxPk24OBQnJP8fdHW9gYNDn46YKRGTWoB@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).