git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	Sverre Rabbelier <srabbelier@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] Set cmdline globally, not in stop_here_user_resolve
Date: Tue, 1 Jun 2010 11:36:58 +0200	[thread overview]
Message-ID: <AANLkTinY8Z-Y_1aFnJrojaAMs68FITt-whC0fLbpIR8h@mail.gmail.com> (raw)
In-Reply-To: <4C04D268.6070908@viscovery.net>

Hi,

> Did you test this? "$0" prints the full path to git-am. This does not
> count as user-friendly in my book!

Doesn't it print out exactly the way you invoke the application ie.
either "./git-am.sh" or "git am"? Then again, when git-am is invoked
internally by git, it possibly uses the full path instead of relying
on $PATH, and this is quite ugly. I noticed that all the other other
shell scripts in git.git also hardcode the string, and there must be a
good reason for this. Therefore I think this particular change should
be dropped.

Thanks for pointing this out.

-- Ram

  reply	other threads:[~2010-06-01  9:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  9:20 [PATCH 0/3] Improve git-am error messages Ramkumar Ramachandra
2010-06-01  9:20 ` [PATCH 1/3] Set cmdline globally, not in stop_here_user_resolve Ramkumar Ramachandra
2010-06-01  9:27   ` Johannes Sixt
2010-06-01  9:36     ` Ramkumar Ramachandra [this message]
2010-06-01  9:20 ` [PATCH 2/3] Display some help text when patch is empty Ramkumar Ramachandra
2010-06-01  9:20 ` [PATCH 3/3] Remove stray error message from sed Ramkumar Ramachandra
2010-06-01 17:44   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinY8Z-Y_1aFnJrojaAMs68FITt-whC0fLbpIR8h@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).