Re: [PATCH] Add two grep config options

[Joe Ratterman <jratt0@gmail.com>]

On Mon, Mar 28, 2011 at 7:13 AM, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>
> On Mon, Mar 28, 2011 at 09:24, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
> > We could safeguard scripts from this by
> >
> > - checking istty and
>
> That should consider running under the pager too.
>
> I had proposed this scheme last year to TopGit as a way to
> differentiate between ui and plumbing. But as Jeff pointed out, this
> is probably not enough.
>
> Bert
>
> > - checking env for GIT_PLUMBING
> >


Thanks for looking over this and taking the time to comment.  I had
not considered the importance of the first line, nor had I noticed the
lack of hyphens in the other options--I copied the name of
grep.extended-regexp from the --extended-regexp grep option.  I can
change those things if the general idea is accepted.  I like the idea
of a single option config key have takes a list of command-line flags,
but I'm not 100% sure I know enough about git code internals to
implement it.  I'll look.

With regard to disabling the line numbering, GNU grep supports both -n
and --line-number.  Adding the latter option to git grep allows for
the long form --no-line-number.  Another option would be to use -N for
the negative, like -h and -H.  GNU grep doesn't support either of
those.


Thanks,
Joe Ratterman