From: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, jnareb@gmail.com, normalperson@yhbt.net,
pasky@ucw.cz
Subject: Re: [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure
Date: Mon, 24 May 2010 20:44:13 +0530 [thread overview]
Message-ID: <AANLkTineGWscmBAY-rjIIEQBNHVyzXUKHJ8WGXd53yCw@mail.gmail.com> (raw)
In-Reply-To: <201005241155.30653.chriscool@tuxfamily.org>
On Mon, May 24, 2010 at 3:25 PM, Christian Couder
<chriscool@tuxfamily.org> wrote:
> Hi Pavan,
>
> On Sunday 23 May 2010 09:32:48 Pavan Kumar Sunkara wrote:
>>
>> This patch is based on 'jn/gitweb-install' in the next branch by Jakub
>> Nareski and my previous 2 patches:
>> * gitweb: Move static files into seperate subdirectory
>> http://article.gmane.org/gmane.comp.version-control.git/147321
>> * gitweb: Set default destination directory for installing gitweb in
>> Makefile http://article.gmane.org/gmane.comp.version-control.git/147160
>
> I tried to apply your 2 patches on top of next I got some errors with the
> "Move static files into seperate subdirectory" patch.
It is a small error in Makefile only with this patch. The others are ok.
I teseted it with alt-git.git repository's next branch.
So, I will be sending only that patch once again.
> Could you resend the 3 patches in a patch series after making sure that they
> apply on top of next?
>
> And I think that it would be better if the web server logs would be in a
> directory with the web server name. For example
> "$fqgitdir/gitweb/$httpd/access.log" instead of "$fqgitdir/gitweb/access.log".
> But it would be nice if you make these changes (as well as the apache2
> confguration changes) in another patch.
>
Yeah. Sure.
- Pavan
next prev parent reply other threads:[~2010-05-24 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 7:32 [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure Pavan Kumar Sunkara
2010-05-23 9:54 ` Jakub Narebski
2010-05-23 9:56 ` Eric Wong
2010-05-23 10:18 ` Pavan Kumar Sunkara
2010-05-24 9:55 ` Christian Couder
2010-05-24 15:14 ` Pavan Kumar Sunkara [this message]
2010-05-25 1:34 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTineGWscmBAY-rjIIEQBNHVyzXUKHJ8WGXd53yCw@mail.gmail.com \
--to=pavan.sss1991@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).