From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Michel Briand <michelbriand@free.fr>
Subject: Re: [PATCH 1/2] t1501: avoid bashisms
Date: Sat, 25 Dec 2010 21:29:20 +0700 [thread overview]
Message-ID: <AANLkTinhrBf14446rJBZSYWTSH6sxOchMcgBsrq8DoLO@mail.gmail.com> (raw)
In-Reply-To: <m2aajudjqt.fsf@whitebox.home>
2010/12/25 Andreas Schwab <schwab@linux-m68k.org>:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> @@ -322,7 +322,10 @@ test_expect_success 'git grep' '
>> test_expect_success 'git commit' '
>> (
>> cd repo.git &&
>> - GIT_DIR=. GIT_WORK_TREE=work git commit -a -m done
>
> In which way is that not portable?
I admit that I rarely leave bash, so I'll quote Johannes answer [1]
-- 8< --
Sure, it is (bashisms). This:
GIT_DIR="$TRASH_DIRECTORY/2/.git" test_repo 2/sub
does not work the same way in all shells when test_repo is a shell
function. You have to export GIT_DIR explicitly before the function call.
(But since in this case, test_repo invokes its own subshell anyway, you
better do it in the function.)
-- 8< --
[1] http://article.gmane.org/gmane.comp.version-control.git/162207
--
Duy
next prev parent reply other threads:[~2010-12-25 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 13:57 [PATCH 1/2] t1501: avoid bashisms Nguyễn Thái Ngọc Duy
2010-12-25 13:57 ` [PATCH 2/2] setup_work_tree: adjust relative $GIT_WORK_TREE after moving cwd Nguyễn Thái Ngọc Duy
2010-12-26 11:46 ` [PATCH] " Nguyễn Thái Ngọc Duy
2010-12-26 11:46 ` [PATCH] setup_explicit_git_dir: " Nguyễn Thái Ngọc Duy
2010-12-27 1:26 ` [PATCH] setup_work_tree: " Nguyễn Thái Ngọc Duy
2010-12-25 14:12 ` [PATCH 1/2] t1501: avoid bashisms Andreas Schwab
2010-12-25 14:29 ` Nguyen Thai Ngoc Duy [this message]
2010-12-25 14:44 ` Nguyen Thai Ngoc Duy
2010-12-26 19:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinhrBf14446rJBZSYWTSH6sxOchMcgBsrq8DoLO@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michelbriand@free.fr \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).