From: Scott Kyle <scott@appden.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: "Kevin Ballard" <kevin@sb.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] completion: Add PS1 configuration for submodules
Date: Tue, 7 Dec 2010 13:17:06 -0800 [thread overview]
Message-ID: <AANLkTinnH4pFaEf=e4YE64f7cwLRx2R_2o_-=JGua30b@mail.gmail.com> (raw)
In-Reply-To: <4CFEA249.907@web.de>
On Tue, Dec 7, 2010 at 1:08 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 07.12.2010 21:31, schrieb Kevin Ballard:
>> On Dec 7, 2010, at 4:15 AM, Ęvar Arnfjörš Bjarmason wrote:
>>
>>> On Tue, Dec 7, 2010 at 00:22, Scott Kyle <scott@appden.com> wrote:
>>>> For those who often work on repositories with submodules, the dirty
>>>> indicator for unstaged changes will almost always show because development
>>>> is simultaneously happening on those submodules. The config option
>>>> diff.ignoreSubmodules is not appropriate for this use because it has larger
>>>> implications.
>>>
>>> Wouldn't it be a lot better to instead add support for showing
>>> submodule dirtyness as distinct from the main tree's dirtyness? Then
>>> you could easily spot if you had either your tree / submodule tree
>>> changes, without just ignoring them.
>>
>> That sounds like a good idea, but it doesn't necessarily have to come with
>> this patch. Scott's use case here is he has a submodule that is _always_ dirty,
>> and he simply doesn't want to see that stuff in the PS1. Having an option to
>> show it separately would be very useful for me, but should perhaps be written
>> as a separate patch.
>
> I'm not sure if I understand your case correctly, but if there is only one
> submodule that is always dirty and everybody knows that but nobody cares,
> won't it make sense to change the "submodule.<name>.ignore" config option
> for that peculiar submodule via .git/config or .gitmodules?
>
If I set the "submodule.<name>.ignore" then diffing around inside my
history will not show the changes to that particular submodule. That
is what I meant by diff.ignoreSubmodules having larger implications.
next prev parent reply other threads:[~2010-12-07 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 23:22 [PATCH] completion: Add PS1 configuration for submodules Scott Kyle
2010-12-07 9:40 ` SZEDER Gábor
2010-12-07 12:15 ` Ævar Arnfjörð Bjarmason
2010-12-07 20:31 ` Kevin Ballard
2010-12-07 21:08 ` Jens Lehmann
2010-12-07 21:17 ` Scott Kyle [this message]
2010-12-07 21:28 ` Jens Lehmann
2010-12-07 21:29 ` Jonathan Nieder
2010-12-07 22:59 ` Scott Kyle
2010-12-12 6:38 ` Jonathan Nieder
2010-12-13 18:12 ` Jens Lehmann
2010-12-21 22:56 ` Scott Kyle
2010-12-07 20:37 ` Scott Kyle
2010-12-07 20:41 ` Kevin Ballard
2010-12-08 0:27 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinnH4pFaEf=e4YE64f7cwLRx2R_2o_-=JGua30b@mail.gmail.com' \
--to=scott@appden.com \
--cc=Jens.Lehmann@web.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).