From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: "ryenus ◇" <ryenus@gmail.com>, git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] repack: find -> /usr/bin/find, as for cygwin
Date: Sat, 19 Mar 2011 23:15:30 +0700 [thread overview]
Message-ID: <AANLkTinncw6GSLf3QvxjqKoaqesH9SWxrn5TENnHDj4Y@mail.gmail.com> (raw)
In-Reply-To: <20110319160754.GA5871@do>
On Sat, Mar 19, 2011 at 11:07 PM, Nguyen Thai Ngoc Duy
<pclouds@gmail.com> wrote:
> I looked at test-lib.sh but forgot git-sh-setup.sh, which does
> aliasing for find in MINGW build. With your patch, the last use of
> find is gone. So we might as well do this
>
> - find () {
> - /usr/bin/find "$@"
> - }
On second thought, no. We probably need to do an unconditional alias
find() {
die "find is not supported"
}
to make sure no one will ever use it again.
--
Duy
next prev parent reply other threads:[~2011-03-19 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 12:08 [PATCH] repack: find -> /usr/bin/find, as for cygwin ryenus ◇
2011-03-19 12:18 ` Nguyen Thai Ngoc Duy
2011-03-19 15:50 ` René Scharfe
2011-03-19 16:07 ` Nguyen Thai Ngoc Duy
2011-03-19 16:15 ` Nguyen Thai Ngoc Duy [this message]
2011-03-19 16:32 ` ryenus ◇
2011-03-19 16:43 ` ryenus ◇
2011-03-19 16:47 ` Nguyen Thai Ngoc Duy
2011-03-19 18:17 ` Junio C Hamano
2011-03-20 0:31 ` ryenus ◇
2011-03-20 0:35 ` ryenus ◇
2011-03-20 7:48 ` Matthieu Moy
2011-03-20 8:42 ` ryenus ◇
2011-03-21 9:36 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinncw6GSLf3QvxjqKoaqesH9SWxrn5TENnHDj4Y@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=ryenus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).