From: knittl <knittl89@googlemail.com>
To: Shawn Pearce <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Match lightweight tags too in bash prompt
Date: Wed, 1 Dec 2010 00:16:38 +0100 [thread overview]
Message-ID: <AANLkTinoZbSqwtiRwZ5+FZyn=6y7usgFi6p-JVUUTM5g@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=0+s164XkWHho1++hvnTCAFg5=GGfMbHF4ugTE@mail.gmail.com>
On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce <spearce@spearce.org> wrote:
> On Fri, Nov 19, 2010 at 7:43 AM, knittl <knittl89@googlemail.com> wrote:
>> From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
>> From: Daniel Knittl-Frank <knittl89+git@googlemail.com>
>> Date: Fri, 19 Nov 2010 16:40:02 +0100
>> Subject: [PATCH] Match lightweight tags too in bash prompt
>>
>> provide `--tags` to git describe
>
> Missing signed-off-by-line.
i mentioned the s-o-b line already in my forward-mail ;)
>> ---
>>
>> bash prompt would display a commit's sha1, when checking out a lightweight tag.
>> provide --tags to git describe in the completion script, so it will
>> display the name
>> of the tag (as it already does for annotated tags)
>
> This information is useful justification for the change. It should
> therefore appear in the commit message, above the --- line.
ok, i'll resend v2 tomorrow morning to you and the mailing list
cheers, daniel
--
typed with http://neo-layout.org
myFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!
next prev parent reply other threads:[~2010-11-30 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 15:43 [PATCH] Match lightweight tags too in bash prompt knittl
2010-11-30 18:04 ` Shawn Pearce
2010-11-30 23:16 ` knittl [this message]
2010-12-01 13:08 ` Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinoZbSqwtiRwZ5+FZyn=6y7usgFi6p-JVUUTM5g@mail.gmail.com' \
--to=knittl89@googlemail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).