git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxin john <maxin@maxinbjohn.info>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Ángel González" <ingenit@zoho.com>,
	"Victor Engmark" <victor.engmark@terreactive.ch>
Subject: Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh
Date: Wed, 30 Mar 2011 21:51:25 +0300	[thread overview]
Message-ID: <AANLkTinrfswqETPVjDEuKon8ntcgUpkizxit84b4imno@mail.gmail.com> (raw)
In-Reply-To: <7vmxkco5jg.fsf@alter.siamese.dyndns.org>

Hi,

>
> I'd just replace /bin/bash with /bin/sh without any other fuss, perhaps
> except for the typofix in the comment, and be done with the topic.
>

I agree with this. The changes were mostly cosmetic and has nothing to
do with the functionality of the script.

>
> Thanks, I'll apply the early hunks from you.
>

Thank you very much.

Best Regards,
Maxin B. John

  reply	other threads:[~2011-03-30 18:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-27 14:37 [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh Maxin john
2011-03-28 21:55 ` Ángel González
2011-03-29  6:54   ` Maxin john
2011-03-29  7:09   ` Junio C Hamano
2011-03-29 22:48     ` Ángel González
2011-03-30  8:52       ` Maxin john
2011-03-30 17:57         ` Junio C Hamano
2011-03-30 18:51           ` Maxin john [this message]
2011-03-31 21:56         ` Junio C Hamano
     [not found]   ` <8721039.4955.1301382568626.JavaMail.trustmail@mail1.terreactive.ch>
2011-03-29 14:03     ` Victor Engmark
2011-03-29  0:16 ` Ángel González
2011-03-29  1:01 ` Junio C Hamano
2011-03-29  6:47   ` Maxin john

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinrfswqETPVjDEuKon8ntcgUpkizxit84b4imno@mail.gmail.com \
    --to=maxin@maxinbjohn.info \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ingenit@zoho.com \
    --cc=victor.engmark@terreactive.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).