git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org, jstpierre@mecheye.net
Subject: Re: URL decoding changed semantics of + in URLs
Date: Fri, 23 Jul 2010 14:10:36 +0000	[thread overview]
Message-ID: <AANLkTinsixPihZRtduuB_0puX_ucC0HYqHPU0UJMX2e-@mail.gmail.com> (raw)
In-Reply-To: <201007231518.31071.trast@student.ethz.ch>

On Fri, Jul 23, 2010 at 13:18, Thomas Rast <trast@student.ethz.ch> wrote:

> doesn't say much about + and the only escaping defined is the usual
> %xx style.  So is there a standard that mandates this, or was it just
> a well-meaning but unnecessary backwards incompatible change?

+ and %20 are as far as I know only interchangable in *query strings*,
so having to clone 'git://git.gnome.org/gtk%2B' where you could
previously clone 'git://git.gnome.org/gtk+' is a bug. Git shouldn't be
changing that + to a %20.

I haven't followed why we need to escape + to %20 at all, even in the
query string. E.g. curl(1) doesn't do that before sending requests to
Apache, which can handle either one. The + v.s. %20 duality is always
handled at the server AFAIK.

  parent reply	other threads:[~2010-07-23 14:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 13:18 URL decoding changed semantics of + in URLs Thomas Rast
2010-07-23 13:21 ` Thomas Rast
2010-07-23 14:10 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-23 14:25   ` Jasper St. Pierre
2010-07-23 21:23   ` [PATCH] Do not unquote + into ' ' " Thomas Rast
2010-07-23 22:20     ` Ævar Arnfjörð Bjarmason
2010-07-23 22:26     ` Junio C Hamano
2010-07-23 23:04       ` Thomas Rast
2010-07-24 14:49         ` [PATCH v2] " Thomas Rast
2010-07-31 21:18           ` Jasper St. Pierre
2010-07-31 21:33             ` Thomas Rast
2010-08-06 10:46               ` Ralf Ebert
2010-07-26 15:40 ` URL decoding changed semantics of + " Jeff King
2010-07-26 17:57   ` Ævar Arnfjörð Bjarmason
2010-07-26 18:22     ` Jasper St. Pierre
2010-07-26 18:30       ` Matthieu Moy
2010-07-26 18:35       ` Ævar Arnfjörð Bjarmason
2010-07-26 18:44         ` Jasper St. Pierre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinsixPihZRtduuB_0puX_ucC0HYqHPU0UJMX2e-@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jstpierre@mecheye.net \
    --cc=peff@peff.net \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).