From: Chad Joan <chadjoan@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Computer Druid <computerdruid@gmail.com>, git@vger.kernel.org
Subject: Re: Git changes permissions on directories when deleting files.
Date: Tue, 1 Mar 2011 15:30:39 -0500 [thread overview]
Message-ID: <AANLkTint3PARNNN4cpic8XG6HsM3AAGuX5a+oeXfFNx=@mail.gmail.com> (raw)
In-Reply-To: <20110301200805.GA18587@sigill.intra.peff.net>
On Tue, Mar 1, 2011 at 3:08 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Mar 01, 2011 at 02:57:19PM -0500, Chad Joan wrote:
>
>> > Exactly. Rather than spend time figuring out if the directory is
>> > removable (which would not be atomic, anyway), we just rmdir and ignore
>> > the error condition.
>> >
>> > I would argue that your filesystem is broken. Even if we implemented a
>> > workaround to opendir() and check for files, it would still have a race
>> > condition that could cause this situation to occur.
>>
>> Ouch.
>>
>> Would it work to do something like alias rmdir to a script or program
>> that would call /bin/rmdir and then fix up the permissions?
>
> Well, we're using the rmdir system call, so you would need a patch to
> git either way. If that was something we wanted to support (with a
> config option, of course), we could do the permissions check-and-restore
> ourselves.
>
> But it just seems horribly broken to me. This is CIFS to an OpenVMS
> machine you said? Do the broken permissions appear to other clients or
> across a remount (i.e., is it broken state in your CIFS client, or has
> the server actually munged permissions)? If so, have you tried reporting
> the issue to whoever writes CIFS server on OpenVMS (is it just samba)?
>
> -Peff
>
Yep, CIFS to OpenVMS.
I don't know about other clients because there are none (yet). The
permission change does survive remounting.
I haven't reported it. I didn't know it existed until now ;)
I'll do that, but it will probably take a long long time for me to see
the patch. I'm hoping there's some cheap hack I can use to work
around it in the meantime.
- Chad
next prev parent reply other threads:[~2011-03-01 20:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 1:42 Git changes permissions on directories when deleting files Chad Joan
2011-03-01 1:45 ` Chad Joan
2011-03-01 2:19 ` Computer Druid
2011-03-01 4:00 ` Chad Joan
2011-03-01 15:51 ` Chad Joan
2011-03-01 17:11 ` Computer Druid
2011-03-01 19:35 ` Chad Joan
2011-03-01 19:44 ` Jeff King
2011-03-01 19:57 ` Chad Joan
2011-03-01 20:08 ` Jeff King
2011-03-01 20:30 ` Chad Joan [this message]
2011-03-01 20:39 ` Computer Druid
2011-03-01 20:57 ` Jeff King
2011-03-01 20:43 ` Matthieu Moy
2011-03-01 20:46 ` Chad Joan
2011-03-01 21:08 ` Jeff King
2011-03-03 3:48 ` Chad Joan
2011-03-03 15:16 ` Jeff King
2011-03-11 6:09 ` Chad Joan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTint3PARNNN4cpic8XG6HsM3AAGuX5a+oeXfFNx=@mail.gmail.com' \
--to=chadjoan@gmail.com \
--cc=computerdruid@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).