git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Scott Kyle <scott@appden.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: Add PS1 configuration for submodules
Date: Tue, 7 Dec 2010 12:37:00 -0800	[thread overview]
Message-ID: <AANLkTinuD2ze_mn5QMLqFaoftwZvTsz-DKv1ojAizg7P@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin8JstkjEWaCGZuqpEXZnLMyudFm24K7Y3iCgX6@mail.gmail.com>

[sorry for the duplicate email, my original was rejected from the list]

On Tue, Dec 7, 2010 at 4:15 AM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> On Tue, Dec 7, 2010 at 00:22, Scott Kyle <scott@appden.com> wrote:
> > For those who often work on repositories with submodules, the dirty
> > indicator for unstaged changes will almost always show because development
> > is simultaneously happening on those submodules. The config option
> > diff.ignoreSubmodules is not appropriate for this use because it has larger
> > implications.
>
> Wouldn't it be a lot better to instead add support for showing
> submodule dirtyness as distinct from the main tree's dirtyness? Then
> you could easily spot if you had either your tree / submodule tree
> changes, without just ignoring them.

I considered that, but thought it to be a rather disruptive change,
and one that conceptually didn't work.  The way I see it, either
somebody thinks of their repo as dirty when the submodules are dirty,
or not. And I think since this behavior has perpetuated for so long,
most users are content with how it currently works.  I, however, was
not, and so that is why I added an option for people like me.

Scott Kyle

http://appden.com
http://github.com/appden
http://twitter.com/appden

  parent reply	other threads:[~2010-12-07 20:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 23:22 [PATCH] completion: Add PS1 configuration for submodules Scott Kyle
2010-12-07  9:40 ` SZEDER Gábor
2010-12-07 12:15 ` Ævar Arnfjörð Bjarmason
2010-12-07 20:31   ` Kevin Ballard
2010-12-07 21:08     ` Jens Lehmann
2010-12-07 21:17       ` Scott Kyle
2010-12-07 21:28         ` Jens Lehmann
2010-12-07 21:29         ` Jonathan Nieder
2010-12-07 22:59           ` Scott Kyle
2010-12-12  6:38             ` Jonathan Nieder
2010-12-13 18:12               ` Jens Lehmann
2010-12-21 22:56                 ` Scott Kyle
2010-12-07 20:37   ` Scott Kyle [this message]
2010-12-07 20:41     ` Kevin Ballard
2010-12-08  0:27       ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinuD2ze_mn5QMLqFaoftwZvTsz-DKv1ojAizg7P@mail.gmail.com \
    --to=scott@appden.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).