From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Pascal Obry <pascal@obry.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] New send-email option smtpserveroption.
Date: Sat, 4 Sep 2010 20:35:43 +0000 [thread overview]
Message-ID: <AANLkTinvos_65kb2uO9bTpRAaCeN+N63-KsMmARadt=3@mail.gmail.com> (raw)
In-Reply-To: <1283630128-3472-4-git-send-email-pascal@obry.net>
On Sat, Sep 4, 2010 at 19:55, Pascal Obry <pascal@obry.net> wrote:
Looks good, but tests are always nice :)
> + unshift (@sendmail_parameters, @smtp_server_options);
> +
It just seems iffy to not be able to provide options without having
the sendmail_parameters. Or maybe all usecases for this involve a
program that takes sendmail-like arguments, so this isn't an issue.
next prev parent reply other threads:[~2010-09-04 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 19:55 [PATCH v2 0/3] Add support for SMTP server options Pascal Obry
2010-09-04 19:55 ` [PATCH v2 1/3] Minor indentation fix Pascal Obry
2010-09-04 19:55 ` [PATCH v2 2/3] Remove @smtp_host_parts variable as not used Pascal Obry
2010-09-04 19:55 ` [PATCH v2 3/3] New send-email option smtpserveroption Pascal Obry
2010-09-04 20:09 ` Pascal Obry
2010-09-04 20:35 ` Ævar Arnfjörð Bjarmason [this message]
2010-09-05 7:15 ` Pascal Obry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinvos_65kb2uO9bTpRAaCeN+N63-KsMmARadt=3@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).