From: Erik Faye-Lund <kusmabite@gmail.com>
To: Jeff King <peff@peff.net>
Cc: JT Olds <jtolds@xnet5.com>, Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tor Arntsen <tor@spacetec.no>,
git@vger.kernel.org
Subject: Re: Git Rebase blows away GIT_AUTHOR_NAME
Date: Mon, 17 Jan 2011 23:29:53 +0100 [thread overview]
Message-ID: <AANLkTinyteSHE6DpBi6mXLW7HpgXkEZL8HBeSuFyw+v2@mail.gmail.com> (raw)
In-Reply-To: <20110117222128.GA30869@sigill.intra.peff.net>
On Mon, Jan 17, 2011 at 11:21 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:
>
>> So we should probably do one or both of:
>>
>> 1. Make an --allow-any-name option to mailinfo, and use it when we
>> invoke mailinfo internally for rebasing. That still doesn't solve
>> the emailed patch problem, but at least keeps purely internal
>> operations sane.
>
> So I wrote up a nice tidy patch series with mailinfo changes and tests,
> and then am/rebase changes and tests on top of that. And guess what I
> noticed? My rebase tests didn't actually fail with stock git.
>
> I bisected to 43c2325 (am: use get_author_ident_from_commit instead of
> mailinfo when rebasing, 2010-06-16), which was written to handle exactly
> this sort of thing.
>
Heh, same story bro :(
Just for reference, my patch can be found at
http://repo.or.cz/w/git/kusma.git work/rebase-keep-name
next prev parent reply other threads:[~2011-01-17 22:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 16:15 Git Rebase blows away GIT_AUTHOR_NAME JT Olds
2011-01-12 18:21 ` Jeff King
2011-01-13 17:00 ` JT Olds
2011-01-13 17:11 ` JT Olds
2011-01-13 17:47 ` Erik Faye-Lund
2011-01-13 17:52 ` JT Olds
2011-01-13 18:20 ` Erik Faye-Lund
2011-01-14 8:45 ` Tor Arntsen
2011-01-14 8:56 ` Erik Faye-Lund
2011-01-14 9:24 ` Tor Arntsen
2011-01-14 9:53 ` Erik Faye-Lund
2011-01-14 14:51 ` JT Olds
2011-01-14 15:41 ` Linus Torvalds
2011-01-14 16:13 ` Erik Faye-Lund
2011-01-14 16:21 ` Jeff King
2011-01-14 16:30 ` Erik Faye-Lund
2011-01-14 16:33 ` Jeff King
2011-01-14 18:02 ` Jay Soffian
2011-01-14 18:28 ` Junio C Hamano
2011-01-14 20:07 ` Jeff King
2011-01-14 22:30 ` Junio C Hamano
2011-01-17 22:21 ` Jeff King
2011-01-17 22:29 ` Erik Faye-Lund [this message]
2011-01-18 3:55 ` JT Olds
2011-01-19 1:33 ` Jay Soffian
[not found] ` <AANLkTimZF+r2aNzrXsUuHVZR65N5wpOYLutFgGAGoci_@m ail.gmail.com>
2011-01-14 16:21 ` Tor Arntsen
2011-01-14 16:26 ` Erik Faye-Lund
2011-01-14 17:18 ` Linus Torvalds
2011-01-14 9:55 ` Erik Faye-Lund
2011-01-13 18:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinyteSHE6DpBi6mXLW7HpgXkEZL8HBeSuFyw+v2@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jtolds@xnet5.com \
--cc=peff@peff.net \
--cc=tor@spacetec.no \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).