From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, jnareb@gmail.com, chriscool@tuxfamily.org,
pasky@ucw.cz
Subject: Re: [PATCHv2] git-web--browse: Add support for google chrome
Date: Wed, 19 May 2010 12:06:29 +0200 [thread overview]
Message-ID: <AANLkTinzbHtabNuDbRRSzyy6a87JeXotiZTq4foR-iVG@mail.gmail.com> (raw)
In-Reply-To: <1274262692-3783-2-git-send-email-pavan.sss1991@gmail.com>
On Wed, May 19, 2010 at 11:51 AM, Pavan Kumar Sunkara
<pavan.sss1991@gmail.com> wrote:
> Add support for another web browser called chrome. To
> select it, the value of the browser is 'chromium'.
>
Extreme nit-pick: This last sentence is a bit outdated now, isn't it?
Both 'chrome' and 'chromium' should work now, right? If you decide to
post another version (I'm not sure it's worth the hassle, though -
this is probably in the who-cares-land), perhaps you should mention
that you're adding support for Chrome AND Chromium?
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-05-19 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 9:51 [PATCHv4 GSoC] gitweb: Move static files into seperate subdirectory Pavan Kumar Sunkara
2010-05-19 9:51 ` [PATCHv2] git-web--browse: Add support for google chrome Pavan Kumar Sunkara
2010-05-19 10:06 ` Erik Faye-Lund [this message]
2010-05-19 10:31 ` Will Palmer
2010-05-19 13:32 ` Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinzbHtabNuDbRRSzyy6a87JeXotiZTq4foR-iVG@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=kusmabite@gmail.com \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).