git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jérémie NIKAES" <jeremie.nikaes@ensimag.imag.fr>
To: Thomas Adam <thomas@xteddy.org>
Cc: git@vger.kernel.org, jrnieder@gmail.com,
	"Arnaud Lacurie" <arnaud.lacurie@ensimag.imag.fr>,
	"Claire Fousse" <claire.fousse@ensimag.imag.fr>,
	"David Amouyal" <david.amouyal@ensimag.imag.fr>,
	"Matthieu Moy" <matthieu.moy@grenoble-inp.fr>,
	"Sylvain Boulmé" <sylvain.boulme@imag.fr>
Subject: Re: [PATCH] Add a remote helper to interact with mediawiki, pull & clone handled
Date: Tue, 7 Jun 2011 00:11:12 +0200	[thread overview]
Message-ID: <BANLkTi=ABYYY7KwVa6=bY_DXXopKnzZOtg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=nOa2B_KNfv-XkYFVr8Ngdd2msFA@mail.gmail.com>

> use warnings; ?

Thanks, added this, showed some uses of undefined variables now fixed.
Will figure in the next patch.
>
>> +use Switch;
>
> Ugh -- no.  This is terrible.  Look at this:
>
> [~]% corelist Switch
> Switch was first released with perl v5.7.3 and removed from v5.13.1
>
> Since you do not specify a minimum perl version you might be alright,
> but for those people on 5.14 -- they won't have this module, for good
> reason.  You can, if you wanted use "given/when" as alternate
> constructs to this.

Yes, as I said to Junio Hamano in my previous mail, that's a mistake
from my part, we don't use switch anymore. Sorry about that

>
>> +use MediaWiki::API;
>> +use Storable qw(freeze thaw);
>
> This might have problems transcending storable formats made on a 32bit
> machine, and then trying to unpack them again on 64bit.  Do you really
> need the need for these storable items to be encoded as binary?

Hmmm that is a leftover use from the script of Jeff King that we used.
We don't use this anymore, so that should not be a problem.

Thanks for your advices !

--
Jérémie Nikaes

      reply	other threads:[~2011-06-06 22:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 10:20 [PATCH] Add a remote helper to interact with mediawiki, pull & clone handled Jeremie Nikaes
2011-06-06 19:28 ` Junio C Hamano
2011-06-06 21:17   ` Jérémie NIKAES
2011-06-06 19:48 ` Thomas Adam
2011-06-06 22:11   ` Jérémie NIKAES [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=ABYYY7KwVa6=bY_DXXopKnzZOtg@mail.gmail.com' \
    --to=jeremie.nikaes@ensimag.imag.fr \
    --cc=arnaud.lacurie@ensimag.imag.fr \
    --cc=claire.fousse@ensimag.imag.fr \
    --cc=david.amouyal@ensimag.imag.fr \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=matthieu.moy@grenoble-inp.fr \
    --cc=sylvain.boulme@imag.fr \
    --cc=thomas@xteddy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).