From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: Bikeshedding advice on the ab/i18n-scripts series
Date: Mon, 16 May 2011 23:32:55 +0200 [thread overview]
Message-ID: <BANLkTi=FLWFzMFG5DgQiaN9kYW3pozJ6HQ@mail.gmail.com> (raw)
In-Reply-To: <20110516212641.GB15150@elie>
On Mon, May 16, 2011 at 23:26, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> That would require us to start extracting strings from all "say"
>> functions. The reason we have only "gettext" and "eval_gettext" is so
>> xgettext can extract them.
>
> Isn't that what the xgettext -k parameter is for?
I'm not saying we can't use xgettext to extract these things. I'm
saying I don't think it's a good idea.
$ git --no-pager grep say git-submodule.sh
git-submodule.sh: say "$(eval_gettext
"Entering '\$prefix\$path'")"
git-submodule.sh: say "$(eval_gettext "Submodule
'\$name' (\$url) registered for path '\$path'")"
git-submodule.sh: say "$(eval_gettext
"Submodule path '\$path' not initialized
git-submodule.sh:
say_msg="$(eval_gettext "Submodule path '\$path': rebased into
'\$sha1'")"
git-submodule.sh:
say_msg="$(eval_gettext "Submodule path '\$path': merged in
'\$sha1'")"
git-submodule.sh:
say_msg="$(eval_gettext "Submodule path '\$path': checked out
'\$sha1'")"
git-submodule.sh: say $say_msg
git-submodule.sh: say "U$sha1 $displaypath"
git-submodule.sh: say "-$sha1 $displaypath"
git-submodule.sh: say " $sha1 $displaypath$revname"
git-submodule.sh: say "+$sha1 $displaypath$revname"
git-submodule.sh: say "$(eval_gettext "Synchronizing
submodule url for '\$name'")"
I want to mark *some* of these *manually* as translatable, I don't
want to go and extract strings from all invocations to functions like
printf & die, instead I want to add a printf(_()) wrapper to
everything.
next prev parent reply other threads:[~2011-05-16 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 16:03 Bikeshedding advice on the ab/i18n-scripts series Ævar Arnfjörð Bjarmason
2011-05-16 16:26 ` Jonathan Nieder
2011-05-16 20:45 ` Junio C Hamano
2011-05-16 20:53 ` Ævar Arnfjörð Bjarmason
2011-05-16 20:58 ` Junio C Hamano
2011-05-16 21:13 ` Ævar Arnfjörð Bjarmason
2011-05-16 21:26 ` Jonathan Nieder
2011-05-16 21:32 ` Ævar Arnfjörð Bjarmason [this message]
2011-05-16 21:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=FLWFzMFG5DgQiaN9kYW3pozJ6HQ@mail.gmail.com' \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).